Clean get_repos() #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use inline function endpoint() - Avoid helper variable "page"
- Use new variable page in while condition - Rename repo_list to all_repos - Rename result to repos - Add comments
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 2769913 | Triggered | Generic High Entropy Secret | e1b4331 | _pkgdown.yml | View secret |
| 2769913 | Triggered | Generic High Entropy Secret | e1b4331 | _pkgdown.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
- add "section lines" for each function - improve indentation and spacing
The functions were copied to separate files!
- change order of commands in order to prolong the pipe - remove column renaming without effect (image_url -> badge_url) - rename result variable to "result"
- use inline expressions instead of helper variables - rename "tmp" to "git_repos"
Extract - get_github_repos_impl() - github_endpoint() - github_repo_object_to_data_row()
Also remove non used arguments and argument defaults
and remove compose_url_opencpu() in favour of compose_url_githubusercontent()
and use the "unset" argument of Sys.getenv()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some major cleaning:
compose_url_*()functionget*_token()functionimage_link()named_link()html_img()html_a()get_repo_infos()was refactored: d636624I also added new functions:
list_files_in_github_repo(): List the files in a GitHub repositoryget_names_of_r_packages_on_github(): What repositories represent (public/private) R packages?make_github_package_db()Create package database from GitHub packagesThis change is