-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making generic solid rocket motors more consistent and realistic #2895
Conversation
I mean, seems fine, but the reason these are horrific is because of their mass ratios, even though 250s Vac is fairly good for the time. It might make sense to make the mass ratio slightly better in that case (preserving total impulse vs when Isp was 250s) |
Good spot on the 230/220 one though, that's ludicrously low nozzle losses. Honestly I'd probably do something like 190/225 for them all, and then tweak the propellant amounts to keep burn time the same, and lower dry mass so total mass remains constant from before? |
Alright, thanks for the feedback. Is the third commit fine btw? (removing the snubotron duplicate) |
Yep, that removal looks fine! You kept the one that adds the TF config, so that's still there. |
Alright good to know. I've run into a confusing problem though. In the config, it says that the separation motor (small) has a volume of only .25, but checking my previous in game screenshots shows it as around 5.09. Any idea what could cause this? |
it's not 0.25, it's |
Thank you! |
Strangely, the dry masses of these separation motors seem to actually be realistic, as checking this source for the shuttle booster separation motor (https://www.northropgrumman.com/wp-content/uploads/NG-Propulsion-Products-Catalog.pdf Page 49) gives a dry weight of 35 kg and a wet weight of 76 kg. (aka a propellant mass of 31 kg, or ~1:0.886 ratio for dry mass:propellant mass) The "radial separation motor (medium)" has the closest ratio to this with about 1:0.804, so I'd say making this ratio about 1:0.9 for all the separation motors would give a good balance, which I'll do by changing the volume. I'll also make it so the small radial separation booster has the same mass/volume as the non-radial version by changing the mass of the medium booster. |
GameData/RealismOverhaul/RO_SuggestedMods/Squad/RO_Squad_Engines.cfg
Outdated
Show resolved
Hide resolved
Per the review comment, that means they're wildly optimistic, since these are 40s or early 50s motors (which should probably be NGNC, but let's not open that can of worms, it'd probably put the variance too high) with steel casings, rather than 90s/2000s motors with (presumably) fiberglass. |
Hm, what do you think I should put the ratio at? If irl it's around 1:0.9, should I put it at around 1:0.8 or 1:0.7? |
The ratio is bad, yes, which is very good for it being in the starting node in RP-1. |
Aw don't you think that's a little harsh? It's not like rocket motor technology drastically changed in a year or two. Also, there's no other rocket motors smaller than that for a long time, so I think it can be buffed a little bit for gameplay reasons. How about it being .05 or .1 less on the right side of the ratio compared to the next node? (which we still need to determine, what should the ratio be for the first unlockable node?) |
there's an obvious better solution to that problem: add another, better, small SRM somewhere later. (pioneer 0/1 being the obvious use case) |
My pull making the mercury posigrade motor 206 isp just got merged, so there's that. I agree that there should be more smaller srm's though. |
Yep, that should be fine (and the Mercury posigrades and retrogrades hopefully don't use a Mercury ECM, which means anyone can use them), so I think 'small higher-tech motors' are covered then. It'd be great if there were more small SRMs, yes. Do BDB have any we're not using yet? We can put them in ROE... |
https://github.com/KSP-RO/RP-1/blob/8ebd7134d59e854e94d04b9a5078ba9add9248f8/Source/Tech%20Tree/Parts%20Browser/data/ROCapsules.json#L3742C20-L3742C20 |
https://github.com/friznit/Unofficial-BDB-Wiki/wiki/Pioneer sure looks like some tiny SRMs under there |
Perhaps this? Unsure if it's referring to that. https://github.com/CobaltWolf/Bluedog-Design-Bureau/blob/master/Gamedata/Bluedog_DB/Parts/ProbeExpansion/Pioneer/bluedog_Pioneer_Engine.dds |
@NathanKell Ah, you keep avoiding my question! Just want to know your thoughts, I'm thinking 1:0.8 for the first node and then 1:0.75 for the starting node. (dry mass:propellant mass) |
But I already told you, in my review and in the above, what I suggested doing for that motor: Change its resource to 1.11 liters, and remove the difference that makes in wet mass from the dry mass. |
Then it'd be great if someone added them to ROE and RP-1. :) |
Made the change to Mercury/Gemini solids. |
…nd lower dry mass unsure if 3.8086 (rounded to 3.81) kg will show up in ksp, since it would be .00381 tons
This reduces the specific impulse of all of the generic solid rocket motors (spin motor, radial separation motor (small/medium/large), separation motor (small)) to 220 in a vacuum and 200 in the atmosphere. I'm unsure if these values are balanced, so I'm open to discussion for them. The purpose of this is to at least make them all consistent with each other.