Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making generic solid rocket motors more consistent and realistic #2895

Merged
merged 10 commits into from
Aug 14, 2023
Merged

Making generic solid rocket motors more consistent and realistic #2895

merged 10 commits into from
Aug 14, 2023

Conversation

Clayell
Copy link
Contributor

@Clayell Clayell commented Aug 8, 2023

This reduces the specific impulse of all of the generic solid rocket motors (spin motor, radial separation motor (small/medium/large), separation motor (small)) to 220 in a vacuum and 200 in the atmosphere. I'm unsure if these values are balanced, so I'm open to discussion for them. The purpose of this is to at least make them all consistent with each other.

@NathanKell
Copy link
Member

I mean, seems fine, but the reason these are horrific is because of their mass ratios, even though 250s Vac is fairly good for the time. It might make sense to make the mass ratio slightly better in that case (preserving total impulse vs when Isp was 250s)

@NathanKell
Copy link
Member

Good spot on the 230/220 one though, that's ludicrously low nozzle losses. Honestly I'd probably do something like 190/225 for them all, and then tweak the propellant amounts to keep burn time the same, and lower dry mass so total mass remains constant from before?

@Clayell
Copy link
Contributor Author

Clayell commented Aug 8, 2023

Good spot on the 230/220 one though, that's ludicrously low nozzle losses. Honestly I'd probably do something like 190/225 for them all, and then tweak the propellant amounts to keep burn time the same, and lower dry mass so total mass remains constant from before?

Alright, thanks for the feedback. Is the third commit fine btw? (removing the snubotron duplicate)

@NathanKell
Copy link
Member

Yep, that removal looks fine! You kept the one that adds the TF config, so that's still there.

@Clayell
Copy link
Contributor Author

Clayell commented Aug 8, 2023

Yep, that removal looks fine! You kept the one that adds the TF config, so that's still there.

Alright good to know. I've run into a confusing problem though. In the config, it says that the separation motor (small) has a volume of only .25, but checking my previous in game screenshots shows it as around 5.09. Any idea what could cause this?

@lpgagnon
Copy link
Contributor

lpgagnon commented Aug 8, 2023

it's not 0.25, it's *= 0.25, i.e. 1/4 of its previous value, which is set here https://github.com/KSP-RO/RealismOverhaul/pull/2895/files#diff-a1c16e44803d091bae08f442608d5ac1832a1b75d133d315b40d0dff6d8b7b27R1213

@Clayell
Copy link
Contributor Author

Clayell commented Aug 8, 2023

it's not 0.25, it's *= 0.25, i.e. 1/4 of its previous value, which is set here https://github.com/KSP-RO/RealismOverhaul/pull/2895/files#diff-a1c16e44803d091bae08f442608d5ac1832a1b75d133d315b40d0dff6d8b7b27R1213

Thank you!

@Clayell
Copy link
Contributor Author

Clayell commented Aug 8, 2023

Strangely, the dry masses of these separation motors seem to actually be realistic, as checking this source for the shuttle booster separation motor (https://www.northropgrumman.com/wp-content/uploads/NG-Propulsion-Products-Catalog.pdf Page 49) gives a dry weight of 35 kg and a wet weight of 76 kg. (aka a propellant mass of 31 kg, or ~1:0.886 ratio for dry mass:propellant mass) The "radial separation motor (medium)" has the closest ratio to this with about 1:0.804, so I'd say making this ratio about 1:0.9 for all the separation motors would give a good balance, which I'll do by changing the volume.

I'll also make it so the small radial separation booster has the same mass/volume as the non-radial version by changing the mass of the medium booster.

@Clayell Clayell changed the title Reducing isp of all generic solid rocket motors Making generic solid rocket motors more consistent and realistic Aug 8, 2023
@NathanKell
Copy link
Member

Strangely, the dry masses of these separation motors seem to actually be realistic...

Per the review comment, that means they're wildly optimistic, since these are 40s or early 50s motors (which should probably be NGNC, but let's not open that can of worms, it'd probably put the variance too high) with steel casings, rather than 90s/2000s motors with (presumably) fiberglass.

@Clayell
Copy link
Contributor Author

Clayell commented Aug 9, 2023

Per the review comment, that means they're wildly optimistic, since these are 40s or early 50s motors (which should probably be NGNC, but let's not open that can of worms, it'd probably put the variance too high) with steel casings, rather than 90s/2000s motors with (presumably) fiberglass.

Hm, what do you think I should put the ratio at? If irl it's around 1:0.9, should I put it at around 1:0.8 or 1:0.7?
Also, the ratio on the spin motor is incredibly terrible, it's around 1:0.435. If we want to keep the same burn time while having a reasonable ratio, then we should increase the thrust. (I have no idea how to calculate what thrust would be needed though)

@NathanKell
Copy link
Member

The ratio is bad, yes, which is very good for it being in the starting node in RP-1.

@Clayell
Copy link
Contributor Author

Clayell commented Aug 9, 2023

The ratio is bad, yes, which is very good for it being in the starting node in RP-1.

Aw don't you think that's a little harsh? It's not like rocket motor technology drastically changed in a year or two. Also, there's no other rocket motors smaller than that for a long time, so I think it can be buffed a little bit for gameplay reasons. How about it being .05 or .1 less on the right side of the ratio compared to the next node? (which we still need to determine, what should the ratio be for the first unlockable node?)

@lpgagnon
Copy link
Contributor

lpgagnon commented Aug 9, 2023

Also, there's no other rocket motors smaller than that for a long time, so I think it can be buffed a little bit for gameplay reasons.

there's an obvious better solution to that problem: add another, better, small SRM somewhere later. (pioneer 0/1 being the obvious use case)

@Clayell
Copy link
Contributor Author

Clayell commented Aug 9, 2023

there's an obvious better solution to that problem: add another, better, small SRM somewhere later. (pioneer 0/1 being the obvious use case)

My pull making the mercury posigrade motor 206 isp just got merged, so there's that. I agree that there should be more smaller srm's though.

@NathanKell
Copy link
Member

Yep, that should be fine (and the Mercury posigrades and retrogrades hopefully don't use a Mercury ECM, which means anyone can use them), so I think 'small higher-tech motors' are covered then.

It'd be great if there were more small SRMs, yes. Do BDB have any we're not using yet? We can put them in ROE...

@lpgagnon
Copy link
Contributor

lpgagnon commented Aug 9, 2023

pioneer 0/1 being the obvious use case

https://github.com/friznit/Unofficial-BDB-Wiki/wiki/Pioneer

sure looks like some tiny SRMs under there

@Clayell
Copy link
Contributor Author

Clayell commented Aug 9, 2023

pioneer 0/1 being the obvious use case

https://github.com/friznit/Unofficial-BDB-Wiki/wiki/Pioneer

sure looks like some tiny SRMs under there

Perhaps this? Unsure if it's referring to that. https://github.com/CobaltWolf/Bluedog-Design-Bureau/blob/master/Gamedata/Bluedog_DB/Parts/ProbeExpansion/Pioneer/bluedog_Pioneer_Engine.dds

@Clayell
Copy link
Contributor Author

Clayell commented Aug 9, 2023

How about it being .05 or .1 less on the right side of the ratio compared to the next node? (which we still need to determine, what should the ratio be for the first unlockable node?)

@NathanKell Ah, you keep avoiding my question! Just want to know your thoughts, I'm thinking 1:0.8 for the first node and then 1:0.75 for the starting node. (dry mass:propellant mass)

@NathanKell
Copy link
Member

But I already told you, in my review and in the above, what I suggested doing for that motor: Change its resource to 1.11 liters, and remove the difference that makes in wet mass from the dry mass.

@NathanKell
Copy link
Member

pioneer 0/1 being the obvious use case

https://github.com/friznit/Unofficial-BDB-Wiki/wiki/Pioneer

sure looks like some tiny SRMs under there

Then it'd be great if someone added them to ROE and RP-1. :)

@NathanKell
Copy link
Member

Made the change to Mercury/Gemini solids.

…nd lower dry mass

unsure if 3.8086 (rounded to 3.81) kg will show up in ksp, since it would be .00381 tons
@NathanKell NathanKell merged commit d936db8 into KSP-RO:master Aug 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants