Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcParts inside a fairing register with a min 1m diameter #21

Open
lpgagnon opened this issue May 22, 2021 · 1 comment
Open

ProcParts inside a fairing register with a min 1m diameter #21

lpgagnon opened this issue May 22, 2021 · 1 comment

Comments

@lpgagnon
Copy link

lpgagnon commented May 22, 2021

Seen with v6.0_RC1 (#fb0326f), don't know how long it's been there

https://discord.com/channels/319857228905447436/620690446540341261/845710042883948574

Place an interstage base with 1 side part, give the base a top & bottom diameter < 1m (say 0.5m). Then place a procparts tank on the base's middle node, and change its diameter.

Expected: with a tank diameter <0.5m, the fairing is a straight cylinder. Tank diameters > 0.5m make the fairing swell out
Actual: fairing diameter swells out to ~1m diameter even with a smaller tank. >1m tanks inflate the fairing as expected

Extra note: the fairing doesn't act as if the full height of the tank is 1m, only its middle(ish) section

@DRVeyl
Copy link

DRVeyl commented May 22, 2021

The surface attachment collider on the ProcPart is, for whatever reason, always positioned at z=0.5 and in the middle of the part. Presumably this is where it starts on an unmodified ProcPart cylinder. So when PF tries to scan everything and determine what is inside, this is identified as something to be kept within the fairing. Thus the minimum radius is found to be 0.5, and it's "correctly" placed at the center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants