[Bug]: current dev version leaves TweakScale folder behind when uninstalling

[JonnyOThan]

Is there an existing issue for this?

• I have searched the existing issues

Operating System

windows 10

CKAN Version

5684cd6

Games

KSP 1

Game Version

1.12.5

Did you make any manual changes to your game folder (i.e., not via CKAN)?

No response

Describe the bug

uninstalling tweakscale can leave folders behind in the dev build. This does NOT occur on the current official release, 1.33.2

Steps to reproduce

1. install tweakscale
2. run the game (I'm not sure if this step is required)
3. close the game
4. uninstall tweakscale with ckan

Relevant log output

No response

[HebaruSan]

I'm not able to reproduce this; my GameData is clean after the uninstall.
Do I have to load a save game? I loaded the main menu and then exited.

[JonnyOThan]

I'm not able to reproduce this; my GameData is clean after the uninstall. Do I have to load a save game? I loaded the main menu and then exited.

Quite possibly, TweakScale creates a config.xml file inside its PluginData but that might not happen until the save is loaded.

[HebaruSan]

Thanks. After starting a save, launching to high suborbital, and exiting, I see that file created:

This shows up at uninstall as expected (though the label sizing needs some adjustment):

... and clicking Delete removes the xml file, the "Scale" folder, and the PluginData folder, but leaves behind Plugins and TweakScale:

Cool, now I can start debugging...

[HebaruSan]

Probably related to #3890.

The unusual thing about this use case is that the mod is not only creating a file in a CKAN-created folder, it's creating a folder in a CKAN-created folder and creating a file inside that. So the updated logic is probably not considering that possibility.