Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceled download keeps downloading in background #2546

Closed
Olympic1 opened this issue Oct 22, 2018 · 6 comments
Closed

Canceled download keeps downloading in background #2546

Olympic1 opened this issue Oct 22, 2018 · 6 comments
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN

Comments

@Olympic1
Copy link
Member

Background

CKAN Version:
The current development version

KSP Version:
1.5.1

Operating System:
Windows 10

Have you made any manual changes to your GameData folder (i.e., not via CKAN)?
Nope

Problem

What steps did you take in CKAN?

  1. Download a mod
  2. Cancel while it is downloading
  3. Go back to Changeset tab

See that it keeps downloading the mod, even if it was canceled

What did you expect to happen?
That it stopped downloading the mod

What happened instead?
It kept downloading the mod. After it was downloaded, it shows up as a cached mod

Screenshots:
image

CKAN error codes (if applicable):
None

@Olympic1 Olympic1 added Bug Something is not working as intended Network Issues affecting internet connections of CKAN Core (ckan.dll) Issues affecting the core part of CKAN labels Oct 22, 2018
@HebaruSan
Copy link
Member

Yup, WebClient.CancelAsync does nothing. I thought this was mentioned in some other issue a while back but I can't find it now.

https://stackoverflow.com/questions/48187976/webclient-cancelasync-file-still-downloading

@politas
Copy link
Member

politas commented Oct 23, 2018

Would #2418 fix this situation?

@HebaruSan
Copy link
Member

I think that one cleans up some GUI quirks without affecting the underlying download code. It would still continue a cancelled download, it would just look better doing it.

@DasSkelett
Copy link
Member

DasSkelett commented Dec 5, 2018

As far as I remember #2418 would not have fixed this, as that was mostly GUI stuff, right.
Edit: I redid #2418 in #2602 , but that changes nothing regarding this issue.

@HebaruSan
Copy link
Member

@HebaruSan
Copy link
Member

In my testing on Windows for #3635, I saw downloads seemingly cancelling. Closing as it no longer seems to happen (maybe some bug fixes in .NET?).

@HebaruSan HebaruSan closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN
Projects
None yet
Development

No branches or pull requests

4 participants