From f52921bb76ad44c4455c70748a0c2c284af40b29 Mon Sep 17 00:00:00 2001
From: Doyoon Kim <doyoon3312@kakao.com>
Date: Wed, 23 Oct 2024 23:41:07 +0900
Subject: [PATCH] [REFACT] Replace Notification Icon.

  - Replace notification icon from SmallIcon to LargeIcon for better visibility.
  - Convert string resource 'notification channel name' into translatable.
---
 .../java/com/doyoonkim/knutice/fcm/PushNotificationHandler.kt | 4 +++-
 app/src/main/res/values-ko-rKR/strings.xml                    | 3 ++-
 app/src/main/res/values/strings.xml                           | 4 ++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/com/doyoonkim/knutice/fcm/PushNotificationHandler.kt b/app/src/main/java/com/doyoonkim/knutice/fcm/PushNotificationHandler.kt
index 8ef4d89..6d52ba0 100644
--- a/app/src/main/java/com/doyoonkim/knutice/fcm/PushNotificationHandler.kt
+++ b/app/src/main/java/com/doyoonkim/knutice/fcm/PushNotificationHandler.kt
@@ -5,6 +5,8 @@ import android.app.NotificationChannel
 import android.app.NotificationManager
 import android.content.Context
 import android.content.pm.PackageManager
+import android.graphics.Bitmap
+import android.graphics.drawable.Icon
 import android.os.Build
 import android.util.Log
 import androidx.core.app.ActivityCompat
@@ -54,7 +56,7 @@ class PushNotificationHandler @Inject constructor() : FirebaseMessagingService()
         val notificationBuilder = NotificationCompat.Builder(
             applicationContext, getString(R.string.inapp_notification_channel_id)
         )
-            .setSmallIcon(R.mipmap.ic_launcher)
+            .setLargeIcon(Icon.createWithResource(applicationContext, R.mipmap.ic_launcher))
             .setContentTitle(getString(R.string.new_notice))
             .setContentText(this@toPushNotification.notification?.body ?: "No message body")
             .setPriority(NotificationCompat.PRIORITY_DEFAULT)
diff --git a/app/src/main/res/values-ko-rKR/strings.xml b/app/src/main/res/values-ko-rKR/strings.xml
index 712f038..b10222c 100644
--- a/app/src/main/res/values-ko-rKR/strings.xml
+++ b/app/src/main/res/values-ko-rKR/strings.xml
@@ -12,8 +12,9 @@
     <string name="about_title">더보기</string>
     <string name="about_version">버전정보</string>
     <string name="about_oss">오픈소스 라이센스</string>
-    <string name="version_code">1.0.0 알파 (내부테스트용)</string>
+    <string name="version_code">1.0.1 알파 (내부테스트용)</string>
     <string name="pref_notification_title">알림</string>
     <string name="title_preference">설정</string>
     <string name="new_notice">새로운 알림이 도착했어요!</string>
+    <string name="inapp_notificaiton_channel_name">신규 공지 알림</string>
 </resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 0dbd9c1..52711f4 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -11,7 +11,7 @@
     <string name="about_title">About</string>
     <string name="about_version">Version</string>
     <string name="about_oss">Open Source License</string>
-    <string name="version_code">1.0.0 Alpha</string>
+    <string name="version_code">1.0.1 Alpha</string>
     <string name="pref_notification_title">Notification</string>
     <string name="title_preference">Preference</string>
     <string name="new_notice">New Notice has been delivered!</string>
@@ -19,5 +19,5 @@
     <string name="default_notification_channel_description" translatable="false">knutice default notification channel for FCM</string>
     <string name="inapp_notification_channel_id" translatable="false">knutice_inapp_notification_channel</string>
     <string name="inapp_notification_channel_description" translatable="false">knutice inapp notification channel</string>
-    <string name="inapp_notificaiton_channel_name" translatable="false">knutice inapp notification Channel</string>
+    <string name="inapp_notificaiton_channel_name">KNUTICE In-app Notice</string>
 </resources>
\ No newline at end of file