Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Dockerfile to make it build and run in a container #628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enhance Dockerfile to make it build and run in a container #628

wants to merge 1 commit into from

Conversation

romixch
Copy link

@romixch romixch commented Oct 3, 2019

Greetings from Hackergarten :-)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 2.258% when pulling 18a5a75 on romixch:master into eab7543 on K2InformaticsGmbH:master.

@romixch
Copy link
Author

romixch commented Oct 3, 2019

This is a contribution to issue #384

stoch
stoch approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@stoch stoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include this 'from scratch' approach for building a docker instance but also follow the alternative approach of using a versioned erlang docker image as a basis. Both approaches have their advantages, depending on the exact requirements.

@c-bik c-bik self-assigned this Oct 8, 2019
c-bik
c-bik requested changes Oct 8, 2019
View reviewed changes
start.sh
@@ -59,7 +59,7 @@ imem_opts=$imem_opts" cold_start_recover false"

# dderl opts
dderl_opts="-dderl"
dderl_opts=$dderl_opts" port $dderlport"
dderl_opts=$dderl_opts" interface \"0.0.0.0\" port $dderlport"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #629 (review) PR default interface are changed to 0.0.0.0 where the env variables are declared. Which makes this redundant.

@c-bik c-bik mentioned this pull request Oct 9, 2019
Open
@c-bik c-bik assigned walter-weinmann and unassigned c-bik Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-bik c-bik c-bik requested changes

@stoch stoch stoch approved these changes

@walter-weinmann walter-weinmann Awaiting requested review from walter-weinmann

Assignees

@walter-weinmann walter-weinmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romixch @coveralls @c-bik @stoch @walter-weinmann