Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use <Picture /> out-of-the-box? #5

Open
h-enk opened this issue Jan 22, 2024 · 2 comments
Open

Use <Picture /> out-of-the-box? #5

h-enk opened this issue Jan 22, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@h-enk
Copy link

h-enk commented Jan 22, 2024

Thanks for this beautiful and high-quality theme!

It would be nice to use the built-in <Picture /> Astro component out-of-the-box — to display a responsive image with multiple formats and/or sizes.

Also note that, the current implementation does not add width and height to an image — causing a LayoutShift — using the <Picture /> component will fix this.

@astab
Copy link
Contributor

astab commented Jan 23, 2024

Thank you @h-enk, I'm glad you like it. Regarding <Picture /> Astro.js component, yes, this is good idea. I will add it in the theme update.

@h-enk
Copy link
Author

h-enk commented Jan 23, 2024

Super!

@astab astab added the enhancement New feature or request label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants