Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate possibility of rewriting our XPath queries to CSS selectors #3184

Open
8 tasks done
JustArchi opened this issue Apr 10, 2024 · 0 comments
Open
8 tasks done
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. ⚪ No priority Issues marked with this label are not being actively worked on for time being. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.

Comments

@JustArchi
Copy link
Member

JustArchi commented Apr 10, 2024

Checklist

Enhancement purpose

Aw sh*t, here we go again...

The history of ASF using XPath is dated back to 2015, when we've used HtmlAgilityPack for parsing HTML files.

It was a very good decision back then, and still is, but since then AngleSharp was released, which turned out to be much more versatile and performant solution. Together with AngleSharp.XPath, rewriting ASF from HAP to AngleSharp turned out much easier than expected.

Solution

As part of further ASF upgrades, we should evaluate whether it's possible to rewrite our XPaths used in ASF to native mechanism provided by AngleSharp, which is CSS selectors exclusively, so we can eventually deprecate usage of AngleSharp.XPath and eventually remove it from the ASF core entirely.

Why currently available solutions are not sufficient?

It's good as it is, however, XPath is community library that extends AngleSharp with features that are not maintained officially. Using native AngleSharp mechanisms will allow us to drop a dependency and improve compatibility with upstream.

Can you help us with this enhancement idea?

Yes, I can code the solution myself and send a pull request

Additional info

No response

@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. ⚪ No priority Issues marked with this label are not being actively worked on for time being. labels Apr 10, 2024
@JustArchi JustArchi changed the title Evaluate possibility of rewriting our XPath requires to CSS selectors Evaluate possibility of rewriting our XPath queries to CSS selectors Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. ⚪ No priority Issues marked with this label are not being actively worked on for time being. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Projects
None yet
Development

No branches or pull requests

1 participant