Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ESLint rules and/or codebase accordingly #1049

Closed
MrBurrBurr opened this issue Jul 21, 2020 · 0 comments · Fixed by #1491
Closed

Update ESLint rules and/or codebase accordingly #1049

MrBurrBurr opened this issue Jul 21, 2020 · 0 comments · Fixed by #1491
Assignees
@MrBurrBurr
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features.

Comments

@MrBurrBurr
Copy link
Member

MrBurrBurr commented Jul 21, 2020 •
edited
Loading

As @Aareksio mentioned in #1022 our ESLint rules are outdated. The codebase and/or the rules should be updated accordingly.
@MrBurrBurr MrBurrBurr added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. Priority: None 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. labels Jul 21, 2020
@MrBurrBurr MrBurrBurr changed the title Update eslint settings to follow latest rules Update ESLint settings to follow latest rules Jul 21, 2020
@MrBurrBurr MrBurrBurr mentioned this issue Jul 26, 2020
Merged
@MrBurrBurr MrBurrBurr added the 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. label Aug 26, 2020
@MrBurrBurr MrBurrBurr changed the title Update ESLint settings to follow latest rules Update ESLint rules and apply to codebase Oct 25, 2020
@MrBurrBurr MrBurrBurr changed the title Update ESLint rules and apply to codebase Update ESLint rules and/or codebase accordingly Oct 25, 2020
@MrBurrBurr MrBurrBurr self-assigned this Oct 25, 2020
@MrBurrBurr MrBurrBurr added 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. and removed Priority: None 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. labels Jan 6, 2021
@MrBurrBurr MrBurrBurr removed their assignment Mar 15, 2021
MrBurrBurr added a commit that referenced this issue Apr 3, 2021
@MrBurrBurr
Require ternary expressions condition to be enclosed by parentheses
718a28c 
Relates to #1049
MrBurrBurr added a commit that referenced this issue Apr 3, 2021
@MrBurrBurr
Update .eslintrc
a53499e 
Relates to #1049
@MrBurrBurr MrBurrBurr added 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. and removed 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. labels Jun 7, 2021
MrBurrBurr added a commit that referenced this issue Jun 29, 2021
@MrBurrBurr
Misc linting refactor
0447caa 
Relates to: #1049
@MrBurrBurr MrBurrBurr mentioned this issue Jul 24, 2021
Merged
@MrBurrBurr MrBurrBurr self-assigned this Aug 23, 2021
@MrBurrBurr MrBurrBurr removed 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. labels Aug 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MrBurrBurr MrBurrBurr

Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve linting errors JustArchiNET/ASF-ui
1 participant
@MrBurrBurr