Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbclassic >=0.5 breaks jupyter_nbextensions_configurator #151

Closed
scmmmh opened this issue Feb 28, 2023 · 13 comments · Fixed by #154
Closed

nbclassic >=0.5 breaks jupyter_nbextensions_configurator #151

scmmmh opened this issue Feb 28, 2023 · 13 comments · Fixed by #154

Comments

@scmmmh
Copy link

scmmmh commented Feb 28, 2023

Hi,

It seems that the nbclassic >= 0.5 releases break the jupyter_nbextensions_configurator extension, because it cannot find the corrected "marked.js" file. It is trying to load "/static/nbclassic/components/marked/lib/marked.js?v=20230228105802", but cannot find that. If I pin nbclassic < 0.5, then it works.

Migrated from jupyter/nbclassic#227.

Best,
Mark

@ego
Copy link

ego commented Feb 28, 2023

I have the same problem
Screenshot 2023-02-28 at 17 05 23

pip install "nbclassic<0.5"

downgrade fix the issue

@mforbes
Copy link

mforbes commented Mar 7, 2023

This is quite problematic for new users. Could a quick release to PyPI pinning nbclassic<0.5 please be made until support for the upgraded marked is provided? (Looks like this is almost done? #152).

@echarles
Copy link
Collaborator

echarles commented Mar 8, 2023

This is quite problematic for new users. Could a quick release to PyPI pinning nbclassic<0.5 please be made until support for the upgraded marked is provided? (Looks like this is almost done? #152).

@juhasch What are your thoughts on this. Should we have a PR that pins to nbclassic<0.5, make a release, and then only after merge #152 and make the release?

@echarles
Copy link
Collaborator

nbclassic 0.5.4 is released and should fix this issue. Can anyone confirm and close this?

@paulhybryant
Copy link

No, I have nbclass 0.5.4 installed, and I am still getting this error.

main.js?v=20230407171327:1001 
        
       [jupyter_nbextensions_configurator] error loading zenmode/main:
TypeError: marked is not a function
build_extension_ui @ main.js?v=20230407171327:1001
render.js?v=20230407171327:155 
        
       Uncaught TypeError: marked is not a function
    at Object.render_markdown (render.js?v=20230407171327:155:13)
    at Object.success (main.js?v=20230407171327:582:26)
    at c (jquery.min.js:2:1)
    at Object.fireWith [as resolveWith] (jquery.min.js:2:1)
    at l (jquery.min.js:2:1)
    at XMLHttpRequest.<anonymous> (jquery.min.js:2:1)

@echarles
Copy link
Collaborator

echarles commented Apr 7, 2023

Thx for reporting @paulhybryant. I have tested in a blank env and the configurator works fine for some of the extensions, but indeed fails for the zenmode - see screenshots below. I would say this is due to an upgrade of zenmode, but is not managed by nbclassic, nor by the configurator extension. The best would be that you open an issue on the zenmode repo.

Screenshot 2023-04-07 at 11 53 09

Screenshot 2023-04-07 at 11 52 54

Screenshot 2023-04-07 at 11 52 57

Screenshot 2023-04-07 at 11 53 30

@xiphl
Copy link

xiphl commented Apr 10, 2023

Hi,
I am seeing the same error message as @paulhybryant in the configurator menu (with nbclassic 0.5.4) when i load the page using browser dev tools.
Although the extensions are generally working (ie I activated ExecuteTime using the checkboxes and observed that the notebook did show the execute timing), the README part for each extensions are not showing up (see screenshot), does anyone have any suggestions on how to solve it?
image
For all the extensions, I observed the same error message:
[jupyter_nbextensions_configurator] error loading <any-extension-in-the-list>/main: TypeError: marked is not a function build_extension_ui @ main.js?v=20230410094859:1001 open_ext_ui @ main.js?v=20230410094859:682 selector_nav_link_callback @ main.js?v=20230410094859:715 dispatch @ jquery.min.js:2 v.handle @ jquery.min.js:2 render.js?v=20230410094859:155 Uncaught TypeError: marked is not a function at Object.render_markdown (render.js?v=20230410094859:155) at Object.success (main.js?v=20230410094859:582) at c (jquery.min.js:2) at Object.fireWith [as resolveWith] (jquery.min.js:2) at l (jquery.min.js:2) at XMLHttpRequest.<anonymous> (jquery.min.js:2)

@paulhybryant
Copy link

Yes, it is not just for zenmode. I didn't event have zenmode enabled. All the markdown description of the plugins have a blank description.

@echarles
Copy link
Collaborator

I have opened #154 that fixes the markdown description. However, zenmode (and potentially others) should be fixed upstream.

@echarles
Copy link
Collaborator

#154 is merged.

Next step is to cut a new release. @juhasch could you help with that?

@echarles
Copy link
Collaborator

@juhasch We need your help for a new release.

@paulhybryant
Copy link

Is there a new release? Thanks!

@echarles
Copy link
Collaborator

@paulhybryant Yes, you can pip instlall jupyter-nbextensions-configurator==0.6.3

https://pypi.org/project/jupyter-nbextensions-configurator/0.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants