Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support getname for symbolic complex numbers #1368

Merged

Conversation

AayushSabharwal
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.21%. Comparing base (2784b7e) to head (06957b4).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/complex.jl 81.81% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1368       +/-   ##
===========================================
+ Coverage    3.98%   79.21%   +75.23%     
===========================================
  Files          51       51               
  Lines        4793     4913      +120     
===========================================
+ Hits          191     3892     +3701     
+ Misses       4602     1021     -3581     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ChrisRackauckas
Copy link
Member

Missing hasname

@ChrisRackauckas
Copy link
Member

But the test fails because it's missing for Complex{Num}

@ChrisRackauckas
Copy link
Member

real test failure.

@ChrisRackauckas ChrisRackauckas merged commit 31e3f6f into JuliaSymbolics:master Nov 20, 2024
9 of 12 checks passed
@AayushSabharwal AayushSabharwal deleted the as/complex-getname branch November 20, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants