Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: OWENSFEA v1.0.0 #118919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Nov 7, 2024

## Initial Registration of the FEA package used by the OWENS toolkit (OWENS.jl)

- This package can be used standalone as a beam FEA solver, or in conjunction with the OWENS toolkit
- See tests and docs for usage

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines which are not met ❌

  • Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.

3. Needs action: here's what to do next

  1. Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
  2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless the AutoMerge issue is that you skipped a version number).

If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.

4. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

UUID: 5906b1e7-6737-4278-91ec-d653c88addb4
Repo: https://github.com/sandialabs/OWENSFEA.jl.git
Tree: 872d077680d9104235c0c9d88797578d97e3097a

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@goerz
Copy link
Member

goerz commented Nov 7, 2024

The name of this package seems problematic, and there also seems to be an issue with the documentation: I can't access the API page. Is this using a custom (broken) CSS file?

In theory, the bot could be made happy by changing the spelling to OwensFEA, but that might have the smell of a (discouraged) "personal package", and more importantly: What is "FEA"? Generally speaking, acronyms that are not widely known should be avoided in package names.

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Nov 7, 2024
@kevmoor
Copy link

kevmoor commented Nov 8, 2024

Thanks @goerz! This is part of the Sandia National Labs OWENS.jl toolkit (Offshore Wind Energy Simulator), so it isn't a personal package. I'm hopeful to register this and several others like it in the coming weeks, so it will be good to address these issues now. My IP folks required me to label all of the packages with the OWENS name, but we might be able to change them if required.

  • OWENS.jl a generalized aero-servo-hydro-elastic wind turbine or hydrokinetic turbine simulator
  • OWENSAero.jl very similar to CCBlade.jl but for vertical axis wind turbines as opposed to horizontal axis turbines
  • OWENSFEA.jl generalized multi-body beam finite analysis very similar to GXBeam.jl but using a different beam model
  • OWENSOpenFASTWrappers.jl a wrapper to the OpenFAST fortran libraries for floating platforms and wind turbine aerodynamics, which we're nearly complete porting the binary creation over to yggdrasil/builarybuilder
  • OWENSPreComp.jl generalized classical laminate theory sectional property generator to go from blade shapes and thicknesses to values usable by the finite element emthods, translated from the fortran PreComp, which is similar to VABS.

Apologies on the docs not building correctly, I'll get that fixed soon.

@goerz
Copy link
Member

goerz commented Nov 8, 2024

Ah! Sorry, I got confused by the thesis by B. C. Owens referenced in the README.

OWENS.jl seems okay to me, which means additional OWENSSomething.jl (including this package) should be fine, too.

Definitely make sure you update the documentation and the README, including with an explanation of the acronym.

Then, after the end of the waiting period, ask for a manual merge on Slack.

@kevmoor
Copy link

kevmoor commented Nov 8, 2024

Roger that, sounds good. Thanks!

@kevmoor
Copy link

kevmoor commented Nov 8, 2024

Block until documentation gets rebuilt properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants