Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preprocess dispatch missing properties #59

Merged
merged 7 commits into from
Oct 21, 2024
Merged

fix preprocess dispatch missing properties #59

merged 7 commits into from
Oct 21, 2024

Conversation

disberd
Copy link
Member

@disberd disberd commented Oct 21, 2024

The previous dispatch rules were sometimes missing the correct processing of Plotly properties when the Dict containing them was Dict{Any} rather than Dict{Symbol}.

Added an if inside the specific method to hopefully handle this. This might also trigger inside arbitrary data Dicts insie the data proerty but should not create problems in those cases.

Fixes #58

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (df2bc6d) to head (27e6c79).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   88.88%   90.06%   +1.17%     
==========================================
  Files          12       12              
  Lines         297      302       +5     
==========================================
+ Hits          264      272       +8     
+ Misses         33       30       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disberd disberd merged commit b54db90 into main Oct 21, 2024
8 checks passed
@disberd disberd deleted the title_fix branch October 21, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pluto.Plotly: title_text does not work in v0.6
1 participant