Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plots do not show within @info #5

Closed
disberd opened this issue May 4, 2022 · 3 comments
Closed

Plots do not show within @info #5

disberd opened this issue May 4, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@disberd
Copy link
Member

disberd commented May 4, 2022

Plot are not correctly rendered currently inside Pluto logs:
image

This is caused by the IO hack that is used to keep persistence between multiple plot objects in the same cell
@disberd
Copy link
Member Author

disberd commented May 4, 2022

Tried the easy fix but stumbled upon a Pluto issue blocking this feature:
fonsp/Pluto.jl#2092

@disberd disberd added the bug Something isn't working label Oct 24, 2022
@disberd
Copy link
Member Author

disberd commented Aug 9, 2023

This was fixed in Pluto with fonsp/Pluto.jl#2607, which is merged but still not released

disberd added a commit that referenced this issue Aug 27, 2023
@disberd
adapt code to support new core_published_to_js
c64fe34 
This uses directly PublishedToJavascript when the function `core_published_to_js` is found
This is because from next Pluto version `publish_to_js` will be deprecated.

This commit also fixes the way automatic counters are computed in order to support logs
In logs the :extra_items key is not added to IO
This will help closing #5
@disberd disberd mentioned this issue Aug 27, 2023
Merged
@disberd
Copy link
Member Author

disberd commented Oct 5, 2023

Closed with #21 and now that Pluto v0.19.28 contains fonsp/Pluto.jl#2607

@disberd disberd closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@disberd