Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the typedarray problem on the JS side #30

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Conversation

disberd
Copy link
Member

@disberd disberd commented Oct 5, 2023

We have to tackle the typedarray problem on the JS side, as avoiding conversion to Float32 still creates some Float64 typed array on JS.
We simply transforms all of these into normal array once the data has been transfered to JS.

This will hopfully fix #25 and #29 for good

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a588e5c) 88.05% compared to head (dec0007) 84.95%.

❗ Current head dec0007 differs from pull request most recent head ccca82c. Consider uploading reports for the commit ccca82c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   88.05%   84.95%   -3.11%     
==========================================
  Files          11       11              
  Lines         201      206       +5     
==========================================
- Hits          177      175       -2     
- Misses         24       31       +7     
Files Coverage Δ
src/show.jl 100.00% <ø> (ø)
src/preprocess.jl 86.27% <28.57%> (-9.38%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disberd disberd merged commit bf23cef into main Oct 5, 2023
3 checks passed
@disberd disberd mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Float32 typed array not supported in layout
1 participant