Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Loading while opening notebook from the menu #18

Open
Illusion47586 opened this issue Sep 3, 2022 · 3 comments
Open

[Feature]: Loading while opening notebook from the menu #18

Illusion47586 opened this issue Sep 3, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request feature-request notebook-opening Opening a notebook
Milestone

Comments

@Illusion47586
Copy link
Member

In which process do you want a new feature?

Opening a file

Feature / Improvement

Currently opening a notebook from the menu shows no loading screen or a progress. It just shows a loading cursor. A loading screen would be nice to inform the user that the file is loading and that anything has not crashed/gone wrong.

Version

0.0.2

@Illusion47586 Illusion47586 added enhancement New feature or request feature-request labels Sep 3, 2022
@Illusion47586 Illusion47586 self-assigned this Sep 3, 2022
@Illusion47586 Illusion47586 added this to the Top Menu milestone Sep 3, 2022
@Illusion47586 Illusion47586 added the notebook-opening Opening a notebook label Sep 3, 2022
@Illusion47586
Copy link
Member Author

Related fonsp/Pluto.jl#2292

@fonsp
Copy link
Member

fonsp commented Oct 10, 2022

@Illusion47586 has this been resolved by fonsp/Pluto.jl#2292 or is there more to do on the PlutoDesktop side?

@Illusion47586
Copy link
Member Author

Illusion47586 commented Oct 10, 2022

@fonsp I am using the latest Pluto.jl version so the loading screen you made is working. The loading screen this issue is talking about seems tricky to implement, because in this case, electron has to kind of tell the frontend when to show a loading screen and when to remove it. So it needs to listen to some event to know when the loading is complete. Also, there is this multi-window issue, i.e. to show the loading screen on which window exactly, because the event would probably not have that information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-request notebook-opening Opening a notebook
Projects
None yet
Development

No branches or pull requests

2 participants