Use StatsAPI instead of StatsBase, define confint and vcov
#231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkofod this would be very nice, should reduce the load time of LsqFit. |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Bump @pkofod 🙂 |
|
CI failure for documentation will be fixed by #247. |
StatsAPI provides a common namespace for packages providing statistical functionality. It supersedes StatsBase's use for this purpose. As part of the migration to using StatsAPI, which is itself non-functional, I've made two functional changes in the form of deprecations of custom functions in favor of their existing StatsAPI equivalents. Namely, `estimate_covar` has been deprecated in favor of `vcov` and `confidence_interval` has been deprecated in favor of `confint`. While the former is a simple renaming, the latter also involves specifying the confidence level rather than the Type I error rate (1 - alpha instead of alpha).
|
The low diff coverage is because this touches some lines that already weren't covered by tests. The <1% change in overall coverage is noise. |
pkofod
approved these changes
Oct 8, 2023
|
appreciate it! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatsAPI provides a common namespace for packages providing statistical functionality. It supersedes StatsBase's use for this purpose.
As part of the migration to using StatsAPI, which is itself a non-functional change, I've made two functional changes in the form of deprecations. Namely,
estimate_covarhas been deprecated in favor ofvcovandconfidence_intervalhas been deprecated in favor ofconfint. While the former is a simple renaming, the latter also involves specifying the confidence level rather than the Type I error rate (1 - alpha instead of alpha). These deprecations will provide a more consistent user experience with other packages that provide statistical functionality.