Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use leja order for factored polynomial, follow up on #568 #587

Merged
merged 6 commits into from
Nov 16, 2024

Conversation

jverzani
Copy link
Member

This adds a leja order to the FactoredPolynomial type when using fromroots.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.80%. Comparing base (d5a472a) to head (a699d85).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   75.77%   75.80%   +0.03%     
==========================================
  Files          38       38              
  Lines        4057     4063       +6     
==========================================
+ Hits         3074     3080       +6     
  Misses        983      983              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinholters
Copy link
Contributor

Should be possible to also test FactoredPolynomial now here:

if P !== FactoredPolynomial
@test fromroots(P, roots(p)) * p[end] p
end

@jverzani jverzani merged commit dc6054b into JuliaMath:master Nov 16, 2024
20 of 24 checks passed
@jverzani jverzani deleted the ordered_dict branch November 16, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants