breaking change for coeffs of Polynominal(0) ?

[johnnychen94]

I'm not sure if this is an intended change, will update the thread if I get more ideas on how the behavior gets affected.

v3.2.8:

julia> using Polynomials

julia> coeffs(Polynomial(0))
1-element Vector{Int64}:
 0

v3.2.9-3.2.12:

julia> using Polynomials

julia> coeffs(Polynomial(0))
Int64[]

[jverzani]

Yes, there was a change here. The basic constructors always trimmed any trailing zeros, and the
zero polynomials were special cased. That was dropped so that zero(T) was not needed to make a zero polynomial. Does it effect anything that you were doing?

[johnnychen94]

Does it effect anything that you were doing?

Yep, when implementing conv or some loops, it would occasionally depend on length(coeffs(p)). I've already gotten a compat patch for this so not much to worry. I just opened this issue to see if there's a need to "fix something upstream" 😆

Please feel free to close this issue if this is an intentional change and you think there's no need to fix it.