From d5a472aa498dc03329ec6e43a5e7c396f9588392 Mon Sep 17 00:00:00 2001
From: Martin Holters <martin.holters@hsu-hh.de>
Date: Wed, 13 Nov 2024 17:37:58 +0100
Subject: [PATCH] Use Leja ordering for `fromroots` (#586)

---
 src/common.jl                                 | 37 ++++++++++++++++++-
 .../standard-basis/standard-basis.jl          |  1 +
 test/StandardBasis.jl                         |  4 ++
 3 files changed, 41 insertions(+), 1 deletion(-)

diff --git a/src/common.jl b/src/common.jl
index b59990ad..d7c9eadd 100644
--- a/src/common.jl
+++ b/src/common.jl
@@ -17,6 +17,41 @@ export fromroots,
        isintegral,
        ismonic
 
+function lejaorder!(roots) # see https://doi.org/10.1023/A:1025555803588
+    if length(roots) <= 2
+        return roots
+    end
+    #ii = argmax(j -> abs(roots[j]), eachindex(roots))
+    ii = firstindex(roots)
+    rmax = abs(roots[ii])
+    for j in eachindex(roots)
+        rabs = abs(roots[j])
+        if rabs > rmax
+            ii = j
+            rmax = rabs
+        end
+    end
+    roots[1], roots[ii] = roots[ii], roots[1]
+    products = abs.(roots .- roots[1])
+    for k in eachindex(roots)[begin+1:end-1]
+        ii = findnext(iszero, products, k) # product[ii] == 0 means that roots[ii] == roots[k-1]
+        if isnothing(ii)
+            #ii = argmax(i -> products[i], k:lastindex(roots))
+            ii = k
+            for j in k+1:lastindex(products)
+                if products[j] > products[ii]
+                    ii = j
+                end
+            end
+        end
+        roots[k], roots[ii] = roots[ii], roots[k]
+        products[k], products[ii] = products[ii], products[k]
+        products .*= abs.(roots .- roots[k])
+    end
+    return roots
+end
+lejaorder(roots) = lejaorder!(copy(roots))
+
 """
     fromroots(::AbstractVector{<:Number}; var=:x)
     fromroots(::Type{<:AbstractPolynomial}, ::AbstractVector{<:Number}; var=:x)
@@ -33,7 +68,7 @@ Polynomial(6 - 5*x + x^2)
 """
 function fromroots(P::Type{<:AbstractPolynomial}, rs; var::SymbolLike = :x)
     x = variable(P, var)
-    p = prod(x-r for r ∈ rs; init=one(x))
+    p = prod(x-r for r ∈ lejaorder(rs); init=one(x))
     p = truncate!!(p)
     p
 end
diff --git a/src/polynomials/standard-basis/standard-basis.jl b/src/polynomials/standard-basis/standard-basis.jl
index a5971506..f78331c3 100644
--- a/src/polynomials/standard-basis/standard-basis.jl
+++ b/src/polynomials/standard-basis/standard-basis.jl
@@ -403,6 +403,7 @@ end
 ## polynomial-roots
 function fromroots(P::Type{<:AbstractDenseUnivariatePolynomial{StandardBasis}}, r::AbstractVector{T}; var::SymbolLike = Var(:x)) where {T <: Number}
     n = length(r)
+    r = lejaorder(r)
     c = zeros(T, n + 1)
     c[1] = one(T)
     for j in 1:n, i in j:-1:1
diff --git a/test/StandardBasis.jl b/test/StandardBasis.jl
index 4fe1d837..7bb84446 100644
--- a/test/StandardBasis.jl
+++ b/test/StandardBasis.jl
@@ -984,6 +984,10 @@ end
             b = fromroots(r)
             (b ≈ a) & isreal(coeffs(b))    # the coeff should be real
         end
+        p = Polynomial([1; zeros(99); -1])
+        if P !== FactoredPolynomial
+            @test fromroots(P, roots(p)) * p[end] ≈ p
+        end
     end
 end