Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random updates #152

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Random updates #152

wants to merge 22 commits into from

Conversation

cscherrer
Copy link
Collaborator

Just a placeholder for now, some of these changes could be rolled back or moved to MeasureTheory

@oschulz
Copy link
Collaborator

oschulz commented Oct 25, 2024

Can we integrate this into #122 ?

@cscherrer
Copy link
Collaborator Author

Can we integrate this into #122 ?

Works for me. Just for context, what's here is a side-effect of me working on some commercial code. As we go, I'm finding pieces of it that aren't core IP and feeding them back upstream to MeasureBase and MeasureTheory. Moving any of the MB-upstreamed stuff into #122 is fine, as long as it doesn't hold up the company work.

Also, there are some other things that aren't here yet that could go into MB. Let's chat about those when you're available and we can make a plan.

@oschulz
Copy link
Collaborator

oschulz commented Oct 26, 2024

what's here is a side-effect of me working on some commercial code

Oh, ok - then let's get it in directly and I'll rebase #122.

Copy link

github-actions bot commented Nov 4, 2024

Package name latest stable
MeasureTheory.jl

Copy link

github-actions bot commented Nov 7, 2024

Package name latest stable
MeasureTheory.jl

Copy link

github-actions bot commented Nov 7, 2024

Package name latest stable
MeasureTheory.jl

Copy link

github-actions bot commented Nov 7, 2024

Package name latest stable
MeasureTheory.jl

Copy link

github-actions bot commented Nov 7, 2024

Package name latest stable
MeasureTheory.jl

Copy link

github-actions bot commented Nov 7, 2024

Package name latest stable
MeasureTheory.jl

Copy link

Package name latest stable
MeasureTheory.jl

Copy link

Package name latest stable
MeasureTheory.jl

Copy link

Package name latest stable
MeasureTheory.jl

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 36.11111% with 23 lines in your changes missing coverage. Please review.

Project coverage is 54.03%. Comparing base (3304a4e) to head (d1e829b).

Files with missing lines Patch % Lines
src/rand.jl 7.69% 12 Missing ⚠️
src/utils.jl 16.66% 5 Missing ⚠️
src/domains.jl 0.00% 2 Missing ⚠️
src/combinators/conditional.jl 0.00% 1 Missing ⚠️
src/combinators/smart-constructors.jl 0.00% 1 Missing ⚠️
src/density-core.jl 66.66% 1 Missing ⚠️
src/parameterized.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   56.32%   54.03%   -2.29%     
==========================================
  Files          44       43       -1     
  Lines        1321     1327       +6     
==========================================
- Hits          744      717      -27     
- Misses        577      610      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants