Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

::StdPowerMeasure{MU,1} pattern #135

Open
cscherrer opened this issue Sep 22, 2023 · 1 comment
Open

::StdPowerMeasure{MU,1} pattern #135

cscherrer opened this issue Sep 22, 2023 · 1 comment

Comments

@cscherrer
Copy link
Collaborator

In product_transport.jl, I see a lot of methods with arguments like

 μ::StdPowerMeasure{MU,1}

This complicates dispatch, and I don't see why it's necessary. @oschulz Why do we need to treat vector specially? I'd think we could just reshape as needed and it could be simpler, but maybe I'm missing something.

@oschulz
Copy link
Collaborator

oschulz commented Sep 23, 2023

Let me take another look - I think there was a reason for it, but I have to remind myself :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants