-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ambiguities #40
base: master
Are you sure you want to change the base?
fix ambiguities #40
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 99.19% 96.92% -2.28%
==========================================
Files 2 6 +4
Lines 373 195 -178
==========================================
- Hits 370 189 -181
- Misses 3 6 +3 ☔ View full report in Codecov by Sentry. |
organise the codes
A crucial line somehow loses coverage. Removing the line results in failed tests. I've added a note to the line. |
Aqua
is set to check ambiguities.Related changes:
NotANumber
toArgumentError
NotANumber
vsArgumentError
#38+∞
now refers toRealInfinity()
. Some+/-
test results have changed accordingly, although not consistent.Infinity
vsRealInfinity()
#39(fld|cld|div)(∞, x)
wherex<0
Aqua
tests are moved to the end of tests to make sure things work before fixing ambiguities.Complex{float} + ∞
min|max
are set to follow Julia base convention, that is,min(x,y)=x
andmax(x,y)=y
ifx==y
. This impactsℵ₀
and∞
specifically. Comparingℵ₀
and∞
#41