Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ambiguities #40

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

fix ambiguities #40

wants to merge 24 commits into from

Conversation

putianyi889
Copy link

@putianyi889 putianyi889 commented Jun 8, 2023

Aqua is set to check ambiguities.

Related changes:

  • Some tests change from NotANumber to ArgumentError NotANumber vs ArgumentError #38
  • Standalone +∞ now refers to RealInfinity(). Some +/- test results have changed accordingly, although not consistent. Infinity vs RealInfinity() #39
  • Support (fld|cld|div)(∞, x) where x<0
  • Aqua tests are moved to the end of tests to make sure things work before fixing ambiguities.
  • Support infinite Complex{float} + ∞
  • min|max are set to follow Julia base convention, that is, min(x,y)=x and max(x,y)=y if x==y. This impacts ℵ₀ and specifically. Comparing ℵ₀ and  #41

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Attention: Patch coverage is 99.11504% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.92%. Comparing base (ea87cbe) to head (5ca6995).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/interface.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   99.19%   96.92%   -2.28%     
==========================================
  Files           2        6       +4     
  Lines         373      195     -178     
==========================================
- Hits          370      189     -181     
- Misses          3        6       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@putianyi889 putianyi889 marked this pull request as ready for review June 10, 2023 15:14
@putianyi889 putianyi889 marked this pull request as draft November 5, 2023 09:02
@putianyi889 putianyi889 marked this pull request as ready for review November 8, 2024 18:07
@putianyi889
Copy link
Author

A crucial line somehow loses coverage. Removing the line results in failed tests. I've added a note to the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant