Use distinct types for RealInfinity #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 99.14% 99.15%
=======================================
Files 2 2
Lines 350 353 +3
=======================================
+ Hits 347 350 +3
Misses 3 3
☔ View full report in Codecov by Sentry. |
fingolfin
reviewed
Aug 22, 2023
| @@ -107,15 +107,17 @@ function mod(x::Real, ::Infinity) | |||
| x | |||
| end | |||
|
|
|||
| abstract type RealInfinity <: Real end | |||
| struct PositiveInfinity <: RealInfinity end | |||
| struct NegativeInfinity <: RealInfinity end | |||
There was a problem hiding this comment.
Good, this also makes those two types into singleton types, which may allow for better code in a few places (avoiding allocations)
|
Wouldn't this be a breaking change? Why not just introduce new types, and keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make it easier to handle ambiguities and conflicts. Old interface is reserved, except for
x.signbitfully replaced bysignbit(x).