Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotANumber vs ArgumentError #38

Open
putianyi889 opened this issue Jun 7, 2023 · 3 comments
Open

NotANumber vs ArgumentError #38

putianyi889 opened this issue Jun 7, 2023 · 3 comments

Comments

@putianyi889
Copy link

Is this behaviour intended? Why is it?

Infinities.jl/test/runtests.jl

Line 41 in 0972ead

@test ∞ - ∞ isa NotANumber

Infinities.jl/test/runtests.jl

Line 163 in 0972ead

@test_throws ArgumentError ∞ + (-∞)

@dlfivefifty
Copy link
Member

The second one is because you can't return the result in a type-stable way.

I'm not sure if NotANumber is actually needed anywhere.... if downstream packages pass with an ArgumentError that could be preferable

@putianyi889
Copy link
Author

The second one is because you can't return the result in a type-stable way.

That's also a point of #37

I'm not sure if NotANumber is actually needed anywhere

It's discussed in #7

@dlfivefifty
Copy link
Member

I'm not sure my argument in #7 holds water as the same would be true for ∞ + (-∞)

@putianyi889 putianyi889 mentioned this issue Jun 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlfivefifty @putianyi889