Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoTable from NaturalEarth has wrong unit #94

Closed
disberd opened this issue Jun 17, 2024 · 3 comments
Closed

GeoTable from NaturalEarth has wrong unit #94

disberd opened this issue Jun 17, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@disberd
Copy link

disberd commented Jun 17, 2024

Hello,

I just realized that the table coming out of the output from NaturalEarth (example https://github.com/JuliaEarth/GeoArtifacts.jl#naturalearth in the Readme) creates a domain whose points are expressed in m, despite having the values which are corresponding to longitude and latitude in degrees.

image

I understand this as that is the default unit to the new Point type, but the input data from the NaturalEarth repository is in latitude/longitude in degrees so at first glance this might seem misleading.

Is this something intended or should it be fixed or made more explicit in the documentation?
Is it alternatively possible to create the geometries directly using LatLon from CoordRefSystems?
I just realized that you can use LatLon to generate a Point, but this would need some modification in the functions in GeoIO to specify how to handle LatLon when converting from GeoJSON.FeatureCollection to:
image

@juliohm
Copy link
Member

juliohm commented Jun 17, 2024

Thanks for opening the issue. This is something that we have in our roadmap: to fix the loaders in GeoIO.jl to consume the CRS metadata in the files, when available.

In other words, this is happening here because we still didn't have time to fix GeoIO.jl loaders with GIS formats. The file should load as LatLon if the geojson/shapefile/... uses geographic coordinates.

@juliohm juliohm transferred this issue from JuliaEarth/GeoArtifacts.jl Jun 17, 2024
@juliohm juliohm added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 17, 2024
@juliohm
Copy link
Member

juliohm commented Jun 17, 2024

I've transferred the issue to GeoIO.jl. PRs are welcome that fix specific loaders.

@juliohm
Copy link
Member

juliohm commented Jun 17, 2024

Closing it in favor of #87

@juliohm juliohm closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants