Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General overhaul #120

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

General overhaul #120

wants to merge 27 commits into from

Conversation

BatyLeo
Copy link
Member

@BatyLeo BatyLeo commented Dec 23, 2024 •
edited
Loading

  • Reorganize src files into losses and layers
  • Remove unnecessary trainings in tests
  • Use DifferentiableExpectations as a dependency
    • Rewrite perturbed using Reinforce
    • Remove probability distributions, and other things that are now in DifferentiableExpectations
    • Now, pushforward and perturbed rrules are located in DifferentiableExpectations
    • accordingly update losses relying on Perturbed
  • Rename GeneralizedMaximizer to LinearMAximizer
  • Use DocStringExtensions for docstrings
  • Remove ThreadsX as a dependency

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.42975% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/layers/perturbed/perturbed.jl 67.85% 9 Missing ⚠️
src/losses/fenchel_young_loss.jl 93.75% 3 Missing ⚠️
src/layers/perturbed/perturbation.jl 85.71% 2 Missing ⚠️
Files with missing lines Coverage Δ
ext/InferOptFrankWolfeExt.jl 100.00% <ø> (ø)
src/InferOpt.jl 100.00% <ø> (ø)
src/interface.jl 100.00% <100.00%> (ø)
src/layers/perturbed/utils.jl 100.00% <100.00%> (ø)
src/layers/regularized/regularized_frank_wolfe.jl 72.72% <100.00%> (ø)
src/layers/regularized/soft_argmax.jl 100.00% <ø> (ø)
src/layers/regularized/soft_rank.jl 71.79% <ø> (ø)
src/layers/regularized/sparse_argmax.jl 100.00% <ø> (ø)
src/layers/simple/identity.jl 77.77% <ø> (ø)
src/layers/simple/interpolation.jl 80.00% <ø> (ø)
... and 11 more

@BatyLeo BatyLeo mentioned this pull request Dec 24, 2024
Closed
4 tasks
This was linked to issues Dec 24, 2024
Weird error when loading DifferentiableFrankWolfe extension #121
Open
Interface with DifferentiableExpectations.jl #117
Open
Get rid of ThreadsX? #67
Open
@BatyLeo BatyLeo removed a link to an issue Dec 25, 2024
Weird error when loading DifferentiableFrankWolfe extension #121
Open
@BatyLeo BatyLeo marked this pull request as ready for review December 25, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interface with DifferentiableExpectations.jl Get rid of ThreadsX?
2 participants
@BatyLeo @codecov-commenter