Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Vcats of AbstractRange can be guaranteed to be vcat #357

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

dlfivefifty
Copy link
Member

@dlfivefifty dlfivefifty commented Dec 6, 2024

@marcusdavidwebb believe it or not, this caused the weird bug yesterday where the -Laplacian was not SPD

@dlfivefifty dlfivefifty changed the title Only Vcats of AbstractUnitRange can be guaranteed to be ranges. Only Vcats of AbstractUnitRange can be guaranteed to be vcat Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (9c908d6) to head (89aa42f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #357   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files          17       17           
  Lines        3183     3185    +2     
=======================================
+ Hits         3046     3048    +2     
  Misses        137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty dlfivefifty changed the title Only Vcats of AbstractUnitRange can be guaranteed to be vcat Only Vcats of AbstractRange can be guaranteed to be vcat Dec 6, 2024
@dlfivefifty dlfivefifty merged commit 97361a4 into master Dec 7, 2024
16 checks passed
@dlfivefifty dlfivefifty deleted the dl/fixreverserangevcat branch December 7, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant