Provide default table object when not parsing into standard format #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
===========================================
- Coverage 90.16% 22.92% -67.25%
===========================================
Files 9 8 -1
Lines 366 349 -17
===========================================
- Hits 330 80 -250
- Misses 36 269 +233
Continue to review full report at Codecov.
|
…ypes or default to a generic one
|
I am thinking about doing no modifications to the existing API, except restrict the tables that can be loaded to ones that we are certain are going to work well. then provide a new API which is a constructor of an XTbML struct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107
improve generic data returned by:
add usage warning via
@inforefactor interim steps to make fewer assumptions about the contents of the table (e.g.
parse_2D_tableassumes indices are issue_age and duration)iterate on generic table API to get to a happy spot
parse table metadata for display methods and/or value index information
how to handle non-contiguous indices? idea: just be
missingfor missing valuesother todo:
docuemnt in API which parts are stable, experimental
add test cases