Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload constructor trait for IteratedModel types #62

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Overload constructor trait for IteratedModel types #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d1469f
bump 0.6.2
ablaom May 31, 2024
67584bf
bump [compat] MLJBase = "1.4"
ablaom May 31, 2024
3bbfab0
overload constructor trait for IteratedModel types
ablaom Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MLJIteration"
uuid = "614be32b-d00c-4edb-bd02-1eb411ab5e55"
authors = ["Anthony D. Blaom <[email protected]>"]
version = "0.6.1"
version = "0.6.2"

[deps]
IterationControl = "b3c1a2ee-3fec-4384-bf48-272ea71de57c"
Expand All @@ -11,7 +11,7 @@ Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"

[compat]
IterationControl = "0.5"
MLJBase = "1.3"
MLJBase = "1.4"
julia = "1.6"

[extras]
Expand Down
6 changes: 2 additions & 4 deletions src/traits.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
MLJBase.is_wrapper(::Type{<:EitherIteratedModel}) = true
MLJBase.caches_data_by_default(::Type{<:EitherIteratedModel}) = false
MLJBase.load_path(::Type{<:DeterministicIteratedModel}) =
"MLJIteration.DeterministicIteratedModel"
MLJBase.load_path(::Type{<:ProbabilisticIteratedModel}) =
"MLJIteration.ProbabilisticIteratedModel"
MLJBase.load_path(::Type{<:EitherIteratedModel}) = "MLJIteration.IteratedModel"
MLJBase.constructor(::Type{<:EitherIteratedModel}) = IteratedModel
MLJBase.package_name(::Type{<:EitherIteratedModel}) = "MLJIteration"
MLJBase.package_uuid(::Type{<:EitherIteratedModel}) =
"614be32b-d00c-4edb-bd02-1eb411ab5e55"
Expand Down
3 changes: 2 additions & 1 deletion test/traits.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ imodel = IteratedModel(model=model, measure=mae)
@test !MLJBase.caches_data_by_default(imodel)
@test !supports_weights(imodel)
@test !supports_class_weights(imodel)
@test load_path(imodel) == "MLJIteration.DeterministicIteratedModel"
@test load_path(imodel) == "MLJIteration.IteratedModel"
@test package_name(imodel) == "MLJIteration"
@test package_uuid(imodel) == "614be32b-d00c-4edb-bd02-1eb411ab5e55"
@test package_url(imodel) == "https://github.com/JuliaAI/MLJIteration.jl"
Expand All @@ -22,6 +22,7 @@ imodel = IteratedModel(model=model, measure=mae)
@test input_scitype(imodel) == input_scitype(model)
@test output_scitype(imodel) == output_scitype(model)
@test target_scitype(imodel) == target_scitype(model)
@test constructor(imodel) == IteratedModel

end

Expand Down
Loading