Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests broken by migration of measures MLJBase.jl -> StatisticalMeasures.jl #56

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Sep 21, 2023

This PR needs:

It only changes tests. No changes to /src.

In this PR we:

  • Adapt tests broken by the migration of measures from MLJBase.jl to StatisticalMeasures.jl

To do:

  • Bump the [compat] for MLJBase

@ablaom ablaom marked this pull request as ready for review September 25, 2023 20:25
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ffb9a25) 96.35% compared to head (f93e85c) 96.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #56      +/-   ##
==========================================
+ Coverage   96.35%   96.93%   +0.58%     
==========================================
  Files           6        7       +1     
  Lines         192      196       +4     
==========================================
+ Hits          185      190       +5     
+ Misses          7        6       -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom ablaom merged commit ab5c2a8 into dev Sep 25, 2023
4 checks passed
This was referenced Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant