From 7bec2b8bd17198034216dea046db6d9ce501d34f Mon Sep 17 00:00:00 2001 From: Julian Rosser Date: Sun, 7 Aug 2016 16:58:00 +0100 Subject: [PATCH 1/3] Fixed readme page --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0ee01db..114bfac 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,8 @@ -# Birthday Reminder 2.3 +# Birthday Reminder 2.4 A simple Material Design Android app which notifies users of upcoming birthdays. ![](http://i.imgur.com/zcF2X4Z.png)![](http://i.imgur.com/PaiXGEV.png) -![](http://imgur.com/VXJWF8g)![](http://i.imgur.com/yC20tDa.png) +![](http://i.imgur.com/VXJWF8g.png)![](http://i.imgur.com/yC20tDa.png) [](https://play.google.com/store/apps/details?id=website.julianrosser.birthdays) From 5e1dde71d7b3440e43a49e0650972b228017573b Mon Sep 17 00:00:00 2001 From: Julian Rosser Date: Wed, 17 Aug 2016 22:29:01 +0100 Subject: [PATCH 2/3] Fixed occasional crash when Cursor wasn't closed properly --- .../birthdays/fragments/ImportContactFragment.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/website/julianrosser/birthdays/fragments/ImportContactFragment.java b/app/src/main/java/website/julianrosser/birthdays/fragments/ImportContactFragment.java index ba072e6..f3e8e77 100644 --- a/app/src/main/java/website/julianrosser/birthdays/fragments/ImportContactFragment.java +++ b/app/src/main/java/website/julianrosser/birthdays/fragments/ImportContactFragment.java @@ -130,7 +130,9 @@ private ArrayList loadContacts() { String name = cur.getString( cur.getColumnIndex(ContactsContract.Contacts.DISPLAY_NAME)); ContentResolver bd = getActivity().getContentResolver(); - Cursor bdc = bd.query(android.provider.ContactsContract.Data.CONTENT_URI, new String[] { ContactsContract.CommonDataKinds.Event.DATA }, android.provider.ContactsContract.Data.CONTACT_ID+" = "+id+" AND "+ ContactsContract.Contacts.Data.MIMETYPE+" = '"+ ContactsContract.CommonDataKinds.Event.CONTENT_ITEM_TYPE+"' AND "+ ContactsContract.CommonDataKinds.Event.TYPE+" = "+ ContactsContract.CommonDataKinds.Event.TYPE_BIRTHDAY, null, android.provider.ContactsContract.Data.DISPLAY_NAME); + Cursor bdc = bd.query(android.provider.ContactsContract.Data.CONTENT_URI, + new String[] { ContactsContract.CommonDataKinds.Event.DATA }, + android.provider.ContactsContract.Data.CONTACT_ID+" = "+id+" AND "+ ContactsContract.Contacts.Data.MIMETYPE+" = '"+ ContactsContract.CommonDataKinds.Event.CONTENT_ITEM_TYPE+"' AND "+ ContactsContract.CommonDataKinds.Event.TYPE+" = "+ ContactsContract.CommonDataKinds.Event.TYPE_BIRTHDAY, null, android.provider.ContactsContract.Data.DISPLAY_NAME); if (bdc != null && bdc.getCount() > 0) { while (bdc.moveToNext()) { String birthday = bdc.getString(0); @@ -139,6 +141,8 @@ private ArrayList loadContacts() { Contact con = new Contact(name, birthday); contactsList.add(con); } + } + if (bdc != null) { bdc.close(); } } From 39f7ac2ce0e6483d1ccae5143417e926ac5f8aa3 Mon Sep 17 00:00:00 2001 From: Julian Rosser Date: Wed, 17 Aug 2016 22:47:20 +0100 Subject: [PATCH 3/3] Updated versionCode and versionName for update 2.4.1 --- app/build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index dfbc1f5..3f80554 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -9,8 +9,8 @@ android { applicationId "website.julianrosser.birthdays" minSdkVersion 11 targetSdkVersion 23 - versionCode 240 - versionName "2.4" + versionCode 241 + versionName "2.4.1" } buildTypes {