fix!: enable deletion of all entities if options.filters of deleteAll…

… is null
Josuto · Jun 1, 2024 · 6dbbad8 · 6dbbad8
1 parent 9a34d9f
commit 6dbbad8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/mongoose.transactional-repository.ts b/src/mongoose.transactional-repository.ts
@@ -4,7 +4,6 @@ import { PartialEntityWithId } from './repository';
 import { TransactionalRepository } from './transactional-repository';
 import { DomainModel } from './util/domain-model';
 import { Entity } from './util/entity';
-import { IllegalArgumentException } from './util/exceptions';
 import {
   DeleteAllOptions,
   SaveAllOptions,
@@ -52,9 +51,6 @@ export abstract class MongooseTransactionalRepository<
 
   /** @inheritdoc */
   async deleteAll(options?: DeleteAllOptions): Promise<number> {
-    if (options?.filters === null) {
-      throw new IllegalArgumentException('Null filters are disallowed');
-    }
     return await runInTransaction(
       async (session: ClientSession) =>
         (await this.entityModel.deleteMany(options?.filters, { session }))

diff --git a/test/repository/book.transactional-repository.test.ts b/test/repository/book.transactional-repository.test.ts
@@ -491,13 +491,12 @@ describe('Given an instance of book repository', () => {
     });
 
     describe('that includes a null filter', () => {
-      it('throws an exception', async () => {
-        await expect(
-          bookRepository.deleteAll({ filters: null as unknown as object }),
-        ).rejects.toThrow(IllegalArgumentException);
+      it('deletes all books', async () => {
+        const deletedBooks = await bookRepository.deleteAll();
+        expect(deletedBooks).toBe(2);
 
         const storedBooks = await bookRepository.findAll();
-        expect(storedBooks).toEqual([storedBook, storedPaperBook]);
+        expect(storedBooks.length).toBe(0);
       });
     });