From f0db0d80d18ec7180406f9f595c384896c10cea0 Mon Sep 17 00:00:00 2001 From: JoshuaDoes Date: Sun, 30 Jul 2023 23:44:53 -0400 Subject: [PATCH] Update recommended volume to 837/15 --- CHANGELOG.md | 2 +- README.md | 18 +++++++++--------- build.sh | 2 +- module/install.sh | 10 +++++++++- module/menu.json | 38 +++++++++++++++++++------------------- module/module.prop | 4 ++-- update.json | 6 +++--- 7 files changed, 44 insertions(+), 36 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2528336..097103a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,3 @@ YOU CANNOT DOWNLOAD THIS UPDATE THROUGH MAGISK'S IN-APP MODULE UPDATER. -You can read the changelog and install this new update here: [Release v2.0.5](https://github.com/JoshuaDoes/pixel-tensor-audio-decompressor/releases/tag/205) \ No newline at end of file +You can read the changelog and install this new update here: [Release v2.1.0](https://github.com/JoshuaDoes/pixel-tensor-audio-decompressor/releases/tag/210) \ No newline at end of file diff --git a/README.md b/README.md index 68211ff..6faa75f 100644 --- a/README.md +++ b/README.md @@ -17,18 +17,18 @@ ## What does this module do? This module will patch and systemlessly replace your mixer_paths.xml to make the following changes (if you choose the recommended preset): -- Raise the digital PCM volume from the stock value of 817 to 865. -- Lower the hardware amplifier gain from the stock value of 17 to 14. +- Raise the digital PCM volume from the stock value of 817 to 837. +- Lower the hardware amplifier gain from the stock value of 17 to 15. - Set the boost peak current limit to the stock value of 3.50A. Some custom ROMs opt to lower it to reduce the heat output, at the expense of your phone's volume potential. Using a newly integrated text menu engine, you may also choose from a variety of presets (PCM/AMP): -- 865/14: The recommended volume by my testing -- 865/13: The original volume from v1.0.0 +- 817/17: The Google stock volume, what you would get without this module +- 837/15: Recommended by the creator of Hifi Maximizer on a Pixel 7 Pro - 865/12: Recommended by a Pixel 7 Pro (cheetah) user -- 837/15: Recommended by the creator of HiFi Maximizer on a Pixel 7 Pro -- 817/17: The Google stock volume -- 913/15: Potentially unsafe! Triggers volume normalization when the volume spikes -- 913/20: Potentially even more unsafe than 913/15! The absolute maximum that can be set +- 865/13: The recommended volume from v1.0.0 +- 865/14: The recommended volume from v2.0.5 +- 913/15: Unsafe! Triggers volume normalization when the volume spikes +- 913/20: Unsafe, moreso than 913/15! The absolute maximum that can be set More presets may be added in future updates, also depending on community feedback. @@ -42,7 +42,7 @@ I've been trialing various increased values for months now using my Pixel 6 Pro, ## How does this affect the audio quality? -The final result with selecting 865/14 is that we have minimized the compression of the PCM audio being sent to our speakers, allowing a wider range of detail. The noise floor has been lowered and the noise ceiling has been raised. You should be able to audibly comprehend better instrument separation, more depth to the notes being played in each instrument (including vocals, or voices and environmental sounds in videos), clarity across the audio spectrum, and a more pronounced bass. And due to the nature of raising the software volume, everything sounds just a little louder than before. This is before even considering something like tuning your EQ settings with an app like Wavelet, which should finally give you some more control over the sound of your audio due to the perceivable lack of detail compression. +The final result with selecting anything higher than the Google stock configuration of 817/17 is that we have minimized the compression of the PCM audio being sent to our speakers, allowing a wider range of detail. The noise floor has been lowered and the noise ceiling has been raised. You should be able to audibly comprehend better instrument separation, more depth to the notes being played in each instrument (including vocals, or voices and environmental sounds in videos), clarity across the audio spectrum, and a more pronounced bass. And due to the nature of raising the software volume, everything sounds just a little louder than before. This is before even considering something like tuning your EQ settings with an app like Wavelet, which should finally give you some more control over the sound of your audio due to the perceivable lack of detail compression. ## How did you determine these values? diff --git a/build.sh b/build.sh index ae6d930..a5c1748 100755 --- a/build.sh +++ b/build.sh @@ -12,7 +12,7 @@ popd () { } echo "* Configuring the build environment" -export VER="v2.0.5" +export VER="v2.1.0" export ZIP="pixel-tensor-audio-decompressor-$VER.zip" export GOOS=linux export GOARCH=arm64 diff --git a/module/install.sh b/module/install.sh index 294ea80..a2ead1a 100644 --- a/module/install.sh +++ b/module/install.sh @@ -4,7 +4,7 @@ print_modname() { ui_print "" ui_print "***********************************" ui_print "* Pixel Tensor Audio Decompressor *" - ui_print " * 2.0.5 * " + ui_print " * 2.1.0 * " ui_print "** Made and tested by JoshuaDoes **" ui_print "***********************************" ui_print "For the following devices:" @@ -37,6 +37,14 @@ on_install() { abort "* Android "$RELEASE" needs testing!" fi + ui_print "If you don't see the menu," + ui_print "close Magisk and try again." + ui_print "" + ui_print "The official Magisk app will" + ui_print "provide the best experience." + ui_print "" + ui_print "AMM also handles the menu well." + ui_print "KernelSU does not like it. :c" sleep 1 export TERM=xterm-256color diff --git a/module/menu.json b/module/menu.json index 2124df0..0583511 100644 --- a/module/menu.json +++ b/module/menu.json @@ -4,7 +4,7 @@ "menus": { "home": { "noGoBack": true, - "title": "Pixel Tensor Audio Decompressor\n JoshuaDoes | v2.0.5 ", + "title": "Pixel Tensor Audio Decompressor\n JoshuaDoes | v2.1.0 ", "subtitle": "\tIf you calibrated wrongly,\n\tclose Magisk and try again.", "items": [ { @@ -18,13 +18,13 @@ "action": "2" }, { - "text": "Use the recommended volume", - "desc": "Applies recommended: 865/14", - "type": "setvar PCM 865 AMP 14", + "text": "Use recommended base: 837/15", + "desc": "Recommended to start with", + "type": "setvar PCM 837 AMP 15", "action": "menu choice" }, { - "text": "Choose a preset volume", + "text": "Try another preset instead", "desc": "You might prefer others!", "type": "menu", "action": "install-choices" @@ -36,15 +36,15 @@ "subtitle": "You might prefer others!", "items": [ { - "text": "865/14", - "desc": "The recommended volume", - "type": "setvar PCM 865 AMP 14", + "text": "817/17", + "desc": "The Google stock volume", + "type": "setvar PCM 817 AMP 17", "action": "menu choice" }, { - "text": "865/13", - "desc": "The volume from v1.0.0", - "type": "setvar PCM 865 AMP 13", + "text": "837/15", + "desc": "Hifi Maximizer best results", + "type": "setvar PCM 865 AMP 12", "action": "menu choice" }, { @@ -54,26 +54,26 @@ "action": "menu choice" }, { - "text": "837/15", - "desc": "Chosen by HiFi Maximizer dev", - "type": "setvar PCM 837 AMP 15", + "text": "865/13", + "desc": "Recommended from v1.0.0", + "type": "setvar PCM 865 AMP 13", "action": "menu choice" }, { - "text": "817/17", - "desc": "The Google stock volume", - "type": "setvar PCM 817 AMP 17", + "text": "865/14", + "desc": "Recommended from v2.0.5", + "type": "setvar PCM 865 AMP 14", "action": "menu choice" }, { "text": "913/15", - "desc": "Unsafe, volume normalization", + "desc": "Unsafe! Triggers protection", "type": "setvar PCM 913 AMP 15", "action": "menu choice" }, { "text": "913/20", - "desc": "Unsafe, absolute maximum", + "desc": "Unsafe! Absolute maximum", "type": "setvar PCM 913 AMP 20", "action": "menu choice" } diff --git a/module/module.prop b/module/module.prop index 75cae83..c2fc810 100644 --- a/module/module.prop +++ b/module/module.prop @@ -1,7 +1,7 @@ id=pixel-tensor-audio-decompressor name=Pixel Tensor Audio Decompressor -version=v2.0.5 -versionCode=205 +version=v2.1.0 +versionCode=210 author=JoshuaDoes description=Patches mixer_paths.xml on Pixel Tensor devices to decompress the digital PCM volume. updateJson=https://raw.githubusercontent.com/JoshuaDoes/pixel-tensor-audio-decompressor/dev/update.json diff --git a/update.json b/update.json index 9b3cd60..c347818 100644 --- a/update.json +++ b/update.json @@ -1,6 +1,6 @@ { - "version": "v2.0.5", - "versionCode": 205, - "zipUrl": "https://github.com/JoshuaDoes/pixel-tensor-audio-decompressor/releases/tag/205", + "version": "v2.1.0", + "versionCode": 210, + "zipUrl": "https://github.com/JoshuaDoes/pixel-tensor-audio-decompressor/releases/tag/210", "changelog": "https://raw.githubusercontent.com/JoshuaDoes/pixel-tensor-audio-decompressor/dev/CHANGELOG.md" }