Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Universal Steam Metadata] Cancelling still tries to fill out Platform #247

Open
chocolatechipcats opened this issue Jan 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@chocolatechipcats
Copy link

Describe the bug
Possibly related to changes made in #5. When searching a game, then pressing the 'cancel' button, Steam Store still tries to import 'PC (Windows),' increasing the chance that it'll be accidentally overwritten.

To Reproduce

  1. Have a game set to 'PC (MS-DOS)' (or any platform other than Windows).
  2. Begin a search with metadata provider 'Steam Store.' Cancel it without selecting a game.
  3. The game will try to import PC (Windows) anyways.

Screenshots
2023-01-02 15_39_52-Select metadata to import

Diagnostics ID
a7a3dab6-e4b0-434d-b5fa-ddccf5b1b977

@chocolatechipcats chocolatechipcats added the bug Something isn't working label Jan 2, 2023
@JosefNemec
Copy link
Owner

I think this was done intentionally in case users changes their mind later, so they can pick that filed from field list on edit game page. This applies to all fields and they shouldn't be actually added to the library in the end, unless you choose to assign them to a game.

@chocolatechipcats
Copy link
Author

As the game didn't even exist on Steam in the first place (I think I clicked it by mistake), it was a little unexpected to have it try to import the platform when I'd cancelled at the the search dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants