Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #157 #195

Merged
merged 3 commits into from
Oct 12, 2023
Merged

issue #157 #195

merged 3 commits into from
Oct 12, 2023

Conversation

Jonghakseo
Copy link
Owner

@Jonghakseo Jonghakseo commented Oct 10, 2023 •
edited
Loading

Fixes a dynamic import bug that was failing intermittently, as suggested by @lookis.

@Jonghakseo Jonghakseo marked this pull request as ready for review October 10, 2023 20:26
@Jonghakseo Jonghakseo mentioned this pull request Oct 10, 2023
Closed
@Jonghakseo Jonghakseo added the fix label Oct 10, 2023
@Jonghakseo Jonghakseo merged commit e067e8c into main Oct 12, 2023
5 checks passed
@Jonghakseo Jonghakseo deleted the fix/issue-157 branch October 12, 2023 18:05
@PatrykKuniczak
Copy link
Collaborator

@Jonghakseo Your module preload break the app.

image

image

@lookis
Copy link

lookis commented Oct 13, 2023

@PatrykKuniczak

please update vite >= 3.2

@PatrykKuniczak
Copy link
Collaborator

@PatrykKuniczak

please update vite >= 3.2

Yeah, my bad i get this package on rebase, but IDN why i'm don't run 'npm i' thanks 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jonghakseo Jonghakseo

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jonghakseo @PatrykKuniczak @lookis