Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native Node WebSockets for hmr #719

Closed
PatrykKuniczak opened this issue Sep 9, 2024 · 1 comment
Closed

Use native Node WebSockets for hmr #719

PatrykKuniczak opened this issue Sep 9, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@PatrykKuniczak
Copy link
Collaborator

PatrykKuniczak commented Sep 9, 2024

Is your feature request related to a problem? Please describe.
Maybe we can handle error from #477 I hope so :)

Describe the solution you'd like
We can implement it anyway, because with this approach we can't avoid dependency which are not longer necessary (since Node 21) :)

PS: We can't do it WebSocketServer that way, because Node doesn't support it :(

@PatrykKuniczak PatrykKuniczak added the enhancement New feature or request label Sep 9, 2024
@PatrykKuniczak PatrykKuniczak added the good first issue Good for newcomers label Sep 9, 2024
@PatrykKuniczak
Copy link
Collaborator Author

It has no sense till node support WebSocketServer, because anyway we still need ws package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants