Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn dev not creating manifest.json on first time #43

Closed
ShuLaPy opened this issue Jan 2, 2023 · 6 comments · Fixed by #44
Closed

yarn dev not creating manifest.json on first time #43

ShuLaPy opened this issue Jan 2, 2023 · 6 comments · Fixed by #44

Comments

@ShuLaPy
Copy link

ShuLaPy commented Jan 2, 2023

Hey,

I cloned the repo and deleted the yarn.lock file as I was facing issues while installing node_modules.

after that as per the steps I run the yarn dev command.
this created a dist folder but the manifest.json was missing.

Screenshot 2023-01-03 at 12 35 59 AM

and because of that, I was getting this error while installing the extension

Screenshot 2023-01-03 at 12 37 32 AM

then I ran the yarn build command which created a manifest.json file successfully

Screenshot 2023-01-03 at 12 37 57 AM


Note: but on subsequent refresh, it creates the manifest.json


@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Thank you for your contribution. We will check and reply to you as soon as possible.

@Jonghakseo
Copy link
Owner

Hi. I just reproduced the above situation and it didn't work.

Is the procedure I checked correct?

  1. Delete node_modules
  2. Delete yarn.lock
  3. Run yarn install
  4. Run yarn dev

manifest.json was created normally into dist folder.
Could you please provide additional information to reproduce the situation?

@ShuLaPy
Copy link
Author

ShuLaPy commented Jan 3, 2023

Here is the video that reproduces this bug

bug.mp4

It's happening for the first time only, after that it works fine.

@Jonghakseo
Copy link
Owner

@ShuLaPy

Thank you! This was a problem that occurred when the first manifest was created only in the public folder and not in the dist.
The PR below solved the problem. Thank you for your contribution.

@Jonghakseo Jonghakseo linked a pull request Jan 4, 2023 that will close this issue
@Jonghakseo
Copy link
Owner

@all-contributors please add @ShuLaPy for bug

@allcontributors
Copy link
Contributor

@Jonghakseo

I've put up a pull request to add @ShuLaPy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants