crash when broadcasting through tor

[chris-belcher]

Got this on irc

<tumblerproblems> Has anyone here had any success running the tumbler script since the 0.2.3 update? By success I mean having the coins reach the destination addresses without requiring a bunch of restarts
<tumblerproblems> Estimated tumbler time was 5 hours. It has been 10 hours and so far 15% of the coins have made it to mix depth 1. The rest are sitting in mix depth 0. right now the script is just sitting receiving pubmsg output from the irc channels
<tumblerproblems> I did get an error earlier when the script tried to connect to a bitcoin peer
<tumblerproblems> "[Thread-7 ] [INFO ] connected Exception in thread Thread-7:"
<tumblerproblems> "peertopeer.py", line 359, in on_heartbeat if (datetime.now() - self.time_marker).total_seconds() < GETDATA_TIMEOUT: AttributeError: 'P2PBroadcastTx' object has no attribute 'time_marker"

The line is here

joinmarket/joinmarket/peertopeer.py

Line 359 in 8c2b6d8

if (datetime.now() - self.time_marker).total_seconds() < GETDATA_TIMEOUT:

So looks like the line self.time_marker = datetime.now() inside on_connected() didnt get called within the heartbeat interval of 30 seconds. Probably this happened because the peer was very slow in sending verack.

I think to fix it there needs to be a new state variable. is_connected, and then on_heartbeat() can return early if that isn't true. This new variable should probably be P2PMessageHandler since it could be used by many subclasses.