Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

social order-by="timestamp" does not result in global ordering #116

Open
lemmy opened this issue Feb 21, 2019 · 9 comments
Open

social order-by="timestamp" does not result in global ordering #116

lemmy opened this issue Feb 21, 2019 · 9 comments

Comments

@lemmy
Copy link

lemmy commented Feb 21, 2019

<aping
  | template-url="social_template.html"
  | items="5"
  | model="social"
  | order-by="timestamp"
  | order-reverse="false"
  | aping-vimeo="[{'channel':'1444158'}]"
  | aping-youtube="['{channelId}':'UCLHtwjeqBxVSEhjV0clKblA']"
  | aping-rss="[{'path':'https://www.reddit.com/r/tlaplus/.rss'},
  | {'path':'https://github.com/tlaplus/tlaplus/releases.atom'},
  | {'path':'https://github.com/tlaplus/tlaplus/commits/master.atom'},
  | {'path':'https://stackoverflow.com/feeds/tag/tla%2b'},
  | {'path':'https://groups.google.com/forum/feed/tlaplus/topics/rss.xml?num=50'}]"
  | aping-codebird="[{'user':'tlaplus', 'result_type':'recent', 'showAvatar':'false'}]"
  | >
  | </aping>
 

My index.html has the following aping stance with order-by="timestamp" but the ordering only seems to affect the local ordering per aping plugin. How do I globally order across all aping plugin (vimeo, youtube, rss, ...)?

@JohnnyTheTank
Copy link
Owner

hi @lemmy
do you still have this issue? for me it works fine: https://aping.readme.io/ (scroll down a bit)
could you please give me more information? maybe a plunkr?

@lemmy
Copy link
Author

lemmy commented May 2, 2019

Thanks for taking the time!

I've created a plunkr with the content served at https://wall.tlapl.us. As you will see, the different RSS feeds listed in index.html are not sorted globally. Instead, it first shows all reddit posts, followed by all SO posts, then GitHub posts, ... (the feed order reddit, SO, GitHub, ... seems to be determined by load time).

@JohnnyTheTank
Copy link
Owner

Okay got it. The problem is most probably the https://github.com/JohnnyTheTank/apiNG-plugin-rss
It seems the plugin is not able to parse the timestamp. I will have a look

@lemmy
Copy link
Author

lemmy commented May 3, 2019

Thanks a lot!

@lemmy
Copy link
Author

lemmy commented Sep 3, 2019

Any updates?

@jlengrand
Copy link

jlengrand commented Sep 25, 2019

Ok folks, please have a look at this : http://plnkr.co/edit/0jPl804FxlfcrOvpzuC7?p=preview

@lemmy, I basically took your plunkr and instead of using the cdn version of aping I used the versions you can get by cloning the repositories (here https://github.com/JohnnyTheTank/apiNG/blob/master/dist/aping.min.js and here https://github.com/JohnnyTheTank/apiNG-plugin-rss/blob/master/dist/aping-plugin-rss.min.js)

Annnnnd, it seems to work...

I was getting crazy about it because cloned the rss plugin repo (https://github.com/JohnnyTheTank/apiNG-plugin-rss) and simply by running grunt and changing the feeds to the ones you use in the plunkr I could not reproduce the bug.

Could it be that something happened to the cdn version?
@lemmy Are you using local or cdn versions on the website?

(BTW, tested on latest chrome and safari)

Versions used (1.4.3 and 0.8.1)

@jlengrand
Copy link

jlengrand commented Sep 25, 2019

See this plunkr : http://plnkr.co/edit/Jjd2hi6BSYQU3f5uj2Y0?p=preview with even less changes to your example.

BTW, were you not missing the order-by="timestamp" part in your first demo?

(Screenshot : https://www.dropbox.com/s/3g1f5hg86a46qri/aping.png?dl=0)

@lemmy
Copy link
Author

lemmy commented Sep 26, 2019

This change seems to make the difference: JohnnyTheTank/apiNG-plugin-rss@df22fe3

@jlengrand Thanks for digging into this.

@jlengrand
Copy link

Will if it's just a version issue then it's great because fixing should be easy:). Nikola asked me to have a look.
Good luck and nice website! I use to have a similar kind of thing for computer vision, nice to see that the concept of planet still exists!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants