Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 6.2.0 for PHP 8 #2

Open
Jimmi08 opened this issue Dec 1, 2023 · 8 comments
Open

Update 6.2.0 for PHP 8 #2

Jimmi08 opened this issue Dec 1, 2023 · 8 comments

Comments

@Jimmi08
Copy link
Member

Jimmi08 commented Dec 1, 2023

PHP Fatal error: Uncaught ValueError: max(): Argument #1 ($value) must contain at least one element \userbar.php:36

@LaocheXe
Copy link
Contributor

LaocheXe commented Jan 1, 2024

Question: userbar.php just makes the images/banners, for the servers correct? Maybe add support for webp - who knows. I'm willing to throw myself at this a little - tried my own game server list - only difference is mine is hard coded in, no admin area - ear server listed has like three files, two php pages, and one js file to auto-refresh cause I cant get the js to just refresh the page - https://501stlegion-a3.com/server_ten.php

@Jimmi08
Copy link
Member Author

Jimmi08 commented Jan 1, 2024

Hi, in fact I am not sure, I am just fixing stuff, you know.
Something like this (It is hard to test it on localhost):
image

@LaocheXe
Copy link
Contributor

LaocheXe commented Jan 1, 2024

Right, so having some game servers can help then. Going to set some up on my testing site.

@Jimmi08
Copy link
Member Author

Jimmi08 commented Jan 1, 2024

There is lgsl 7 on the way, so I didn't want to change files too much. But if there is need, more of stuff can be replaced by e107 (e107::getDb()) and so. Only it will complicate next update, so I haven't touched it.

@LaocheXe
Copy link
Contributor

LaocheXe commented Jan 1, 2024

True, I mean we can tinker a little with it, and see what LGSL 7 looks like - https://testing.501stlegion-a3.com/LGSL/

So Index.php needs a look at, have links that return nothing on my end, For example when I click on the TeamSpeak 3 server i get a url - index.php?s=ts3.501stlegion-a3.c%E2%80%8Bom%E2%80%8B <-- idk if it calls for userbar or not on the index so not sure - the other teamspeak 3 link works because it connects you to the server - all them work but the arma 3 ones, the servers use mods and they would need to be added to the link kind of like my Voice eXe plugin with the custom links but thats something else to deal with.

@Jimmi08
Copy link
Member Author

Jimmi08 commented Jan 1, 2024

You have there fatal error Fatal error: Uncaught Error: Call to a member function retrieve() on null in /usr/www/taskforce13tsw/501st/e107-test/e107_plugins/calendar_menu/calendar_menu.php

I need your preferences - just export them from export tools.

My test data looks like this:
image
My URLs looks correct, your are ugly. Maybe spaces in names?

image

@LaocheXe
Copy link
Contributor

LaocheXe commented Jan 1, 2024

That fatal error is for out-dated event calendar menu (NFOServers controls the php version, and forced it to 8.something) - was on php 7.4 for the longest.

I'll come around to fix that later on. As for the space, I didn't give the names, just added the IP/Host, Connection Port, and Query Port - I don't know what software port is.

lgsl_e107Export_2024-01-01.zip

@Jimmi08
Copy link
Member Author

Jimmi08 commented Jan 2, 2024

You should first install lgsl as a standalone version, then check the e107 version - to see where the is problem.
Version 6 is not for PHP 8 either if I know.
Thanks for data.
By the way - that fatal error can influence this plugin too. If you use my version of the calendar plugin, report it and I will try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants