-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in "draw your own wave", when moving harmonic slider then redrawing wave #22
Comments
Hi. Could you explain what you would thinking the intended behaviour is? |
Whoops, accidentally clicked closed! From your description, it sounds like it's doing what I would think it should do -- as the wave that you see changes, the sound that plays changes too. |
If you move the harmonic-count slider to the left and redraw the wave, the slider moves to the right, but the wave (in the right pane, and when played back) remains filtered (as if the slider remained on the left). And if you move the slider a single pixel, the right pane and the playback jump to "unfiltered". This is a logical inconsistency and a bug. Either the slider should reset and the wave should not be filtered, or the slider should remain as-is and the wave should be filtered. I recorded a screencast at https://youtu.be/x0fnbw_75H0 . (Also sometimes I clicked the button but did not hear a sound. Is that a bug too?) As for the "keep spamming Play" part, that may not be a bug, but a choice of behavior. |
I found a second bug. If I move the slider, then draw/edit the wave, the wave will start out extremely tall then zoom to its normal size. The sound is not amplified when the wave is tall. I recorded a video where I edited the wave (unnecessary for reproducing bug) before moving the slider and editing the wave. https://youtu.be/CKSk8OiRy8I 70.0 (64-bit), Windows 10 x64. |
Thanks for attaching the videos! You're right, that is weird and is a bug! If I get time I'll take a look, shouldn't be too hard to fix. |
If you move the harmonic-count slider to the left and redraw the wave, the slider moves to the right. If you press Play right after redrawing the wave, the harmonics are there. If you keep spamming Play as the right side of the image animates into a filtered wave, the quieter (not necessarily upper) harmonics gradually fade into silence.
The text was updated successfully, but these errors were encountered: