Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in editor button #230

Open
CarsonBurke opened this issue Aug 30, 2024 · 4 comments
Open

Open in editor button #230

CarsonBurke opened this issue Aug 30, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@CarsonBurke
Copy link

Similar to the terminal open button with a configurable runner (or default if the user doesn't add one), an open in editor button would be placed on the top right toolbar. The icon would be a pen or notepad, and the text below would say "Editor"

image
(Around where the new button would be located)

This reduces time for developers working often with multiple repositories using the UI, as the current alternative, as far as I can tell, is Actions -> Open in file manager -> in file manager: open with -> code editor. It also has a nice UX, and might be expected by developers coming from GUIs like Github Desktop

image
(from GitHub Desktop)

I would love to do it myself but I'm not so familiar with java and the libraries in use here. Thank you to everyone for their work on this excellent project.

@CarsonBurke CarsonBurke added the enhancement New feature or request label Aug 30, 2024
@CarsonBurke CarsonBurke changed the title Open in editor Open in editor button Aug 30, 2024
@JetpackDuba
Copy link
Owner

JetpackDuba commented Sep 3, 2024

Thanks for your support and your suggestion! 😄

I've tought about it in the past but I wasn't really sure about it.

I still have to check how does GitHub Desktop manage it but here is my take on what I think could be nice:

  • Move open in file manager with the terminal button as a drop down (like in the pull/push options)
  • Add option to open in code editor
    • In the settings there should be a default path to the code editor like we currently have for a custom terminal.
    • There should be an option to set a specific editor for a specific repository (I could have vscode by default but use Intellij IDEA for one specific project like it could be Gitnuro itself).

@CarsonBurke
Copy link
Author

That sounds great. Thank you for your thoughtful response.

@Escain
Copy link

Escain commented Sep 11, 2024

This is really needed, but I think that the editor should be open for a specific file, thus, should be a right-click on a file -> "Open in editor"

  • On the current working directory: open the file as it is.
  • On the history (less important, but would be also great): opens that version of the file.

@JetpackDuba
Copy link
Owner

I had an "open in editor" in the past but ended up removing it because it had quite bad UX for big files (it should allow the user to also open or copy binary files in LFS).

But yes, it would be a nice addition, at least for plain text files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants