incsearch seems slightly broken?

[pop-cultural-reference]

Frequently incsearch seems to be taking me to lines with no match. I think it happens more often at least if the search is at least around 4 characters (probably because the match is then off-screen?). Given a file, search string, and starting point it seems the place it scrolls to is consistent, but eg deleting a character or adding a character sometimes seems to bring me to a real match.

If I press enter though, it always jumps to a real match even if it was on a line with no match.

I've tried commenting out all of my ideavimrc; updating pycharm; uninstalling and reinstalling ideavim; and disabling EasyMotion all without any luck.

Unfortunately I can't share my code, but this is happening often enough that I would have thought other people are running into it?

[AlexPl292]

Hi, could you please share your log (https://intellij-support.jetbrains.com/hc/en-us/articles/207241085-Locating-IDE-log-files) ?

[pop-cultural-reference]

Definitely: idea_logs.zip

Thanks for taking a look!

edit: Ah, sorry for "answering" instead of replying to your answer.

[AlexPl292]

Wow, I really reproduced that with this file. I placed a caret on line 311 and started search. Thank you, I'll take a look!

[citizenmatt]

OMG

I have no idea how this bug has not been found before. It's moving the caret/current line to the offset of the first match in the current document in the next open project. 🙀

I couldn't resist diving in to this one. I couldn't understand what I was seeing in that video - the result on line 328 was being highlighted as the current result, but the current line was being set to 331. These should have been using the same offset. Unless we return a different offset, and that could only happen if we have multiple projects open at the same time. And, well, yeah.

Screen.Recording.2022-08-18.at.8.49.44.pm.mov

See how the caret line in the editor on the right updates to the same line as the next match found in the editor on the left.

We want IdeaVim to behave like Vim and highlight search results in all open windows (editors) of the document. To get all of the editors, we need an instance of the current project, which we don't have at that point, so we loop over ALL open projects, get the current editor and use that editor's document to find the other editors and highlight everything. But we're missing a few checks, so we a) highlight documents in the wrong project and b) return the next match offset from the wrong editor and therefore c) move the current caret line to the wrong place.

What a brilliant bug 😁

[AlexPl292]

Wow, haven't seen Matt that excited :D
The bug is really interesting

[citizenmatt]

I do like a good scrolling bug :)

[citizenmatt]

I forgot to record an issue for this bug: VIM-2779.