Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve/completion for wrappers #310

Merged
merged 61 commits into from
Dec 18, 2020

Conversation

SimonTsirikov
Copy link
Contributor

Fixes #18

SimonTsirikov and others added 30 commits July 17, 2020 16:23
…n creating dir base project in PyCharm added 3) facet settings validator added
…k impl added. Now is ok to use intellij API in SmkWrapperCrawler.kt
… wrapper. If folder doesn't contain `meta.yaml` it isn't a wrapper
* restrict warning area from PyReferenceExpression to PyFunction
@SimonTsirikov
Copy link
Contributor Author

If user starts typing name of wrapper, bundled version is suggested.
Screenshot from 2020-08-31 13-34-15
But if user types version first and it matches regex (\d+\.\d+\.\d+|master|latest).*, this version is suggested instead of bundled one.
Screenshot from 2020-08-31 13-35-03
Screenshot from 2020-08-31 13-35-26

@iromeo
Copy link
Contributor

iromeo commented Aug 31, 2020

Changed wrappers root from bundled to my custom dir /Users/romeo/PycharmProjects/snakecharm_tests/wrappers but completion shows old bundled information

Update: Also on facet enabled in project w/o facet - wrappers list aren't updated. After the project re-open - the wrappers info is loaded correctly.

image

image

@iromeo
Copy link
Contributor

iromeo commented Aug 31, 2020

If user starts typing name of wrapper, bundled version is suggested.
Ok, thx for fix

@iromeo
Copy link
Contributor

iromeo commented Aug 31, 2020

Params parsing false positive: Wrapper sections detection false positive: 'shell' is missing #311

@iromeo
Copy link
Contributor

iromeo commented Aug 31, 2020

Also see #312

iromeo and others added 22 commits September 8, 2020 21:19
…ge folder, load test data in tests instead 2) build wrappers in 'build' dir, not src dir (tmp disabled)
… in params, resolves #326 3) completion contributors cleanup
…apply" facet settings in PyCharm 3) Fixed validation for wrappers folder path 4) configurables renamed 5) messages updated 6) apply facets parsing/loading in bg
…/deserialization

Cleanup XML serialization for wrappers #325

Wrong wrapper name suggestion when using custom wrappers location #342
@iromeo iromeo merged commit ee0915b into master Dec 18, 2020
@iromeo iromeo deleted the features/#18-resolve-completion-for-wrappers branch August 16, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snakemake wrappers resolve/completion
3 participants