Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows composer.json problem #167

Open
MimisK13 opened this issue Oct 31, 2023 · 1 comment
Open

Windows composer.json problem #167

MimisK13 opened this issue Oct 31, 2023 · 1 comment

Comments

@MimisK13
Copy link
Contributor

On Windows there is the following problem:

  "test/test4": {
      "type": "path",
      "url": "C:\\xampp\\htdocs\\FORKED\\package-testing\\packages/test/test4",
      "options": {
          "symlink": true
      }
  },

The problem is fixed with the following modification:

// FileHandler.php

public function vendorPath()
{
    return $this->packagesPath().'\\'.$this->vendor();
}

public function packagePath()
{
    return $this->vendorPath().'\\'.$this->package();
}

The result is now correct:

"test/test5": {
    "type": "path",
    "url": "C:\\xampp\\htdocs\\FORKED\\package-testing\\packages\\test\\test5",
    "options": {
        "symlink": true
    }
},

PS I don't know if this affects MacOS

Is it ok if I open a PR for this?

@Jeroen-G
Copy link
Owner

Jeroen-G commented Nov 1, 2023

Nice job on describing the issue and working on the PR! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants