Bugfix: User-defined factory generators #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User-defined JFactoryGenerators can't be trusted to furnish the JFactories they create with a JApplication pointer. We don't have any opportunity to inject the JApplication pointer and logger until JFactory::Create, so we do it there.
On real-world-sized projects, this summary is far too long. It overwhelms the other log output and isn't particularly helpful for debugging.
nathanwbrei
force-pushed
the
nbrei_facgen_fix
branch
from
b53688e to
1fce6d5
Compare
nathanwbrei
force-pushed
the
nbrei_facgen_fix
branch
from
1fce6d5 to
5dbbbfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in the previous release meant that user-defined factory generators can create factories with null JApplication pointers.
This PR also removes some deprecated functionality: