diff --git a/src/libraries/JANA/Compatibility/JLockService.h b/src/libraries/JANA/Compatibility/JLockService.h index 96072b692..4e5f4d1ba 100644 --- a/src/libraries/JANA/Compatibility/JLockService.h +++ b/src/libraries/JANA/Compatibility/JLockService.h @@ -19,8 +19,6 @@ class JLockService : public JService { } ~JLockService() override { - delete m_app_rw_lock; - delete m_root_rw_lock; for (const auto& pair : m_rw_locks) { delete pair.second; } @@ -70,8 +68,8 @@ class JLockService : public JService { private: std::map m_rw_locks; - pthread_rwlock_t *m_app_rw_lock; - pthread_rwlock_t *m_root_rw_lock; + pthread_rwlock_t *m_app_rw_lock = nullptr; + pthread_rwlock_t *m_root_rw_lock = nullptr; pthread_rwlock_t m_rw_locks_lock {}; // control access to rw_locks pthread_rwlock_t m_root_fill_locks_lock {}; // control access to m_root_fill_rw_lock std::map m_root_fill_rw_lock; diff --git a/src/libraries/JANA/JEventSource.h b/src/libraries/JANA/JEventSource.h index c3cc96048..960a0c554 100644 --- a/src/libraries/JANA/JEventSource.h +++ b/src/libraries/JANA/JEventSource.h @@ -40,7 +40,6 @@ class JEventSource : public jana::components::JComponent, public: - [[deprecated]] explicit JEventSource(std::string resource_name, JApplication* app = nullptr) : m_resource_name(std::move(resource_name)) { m_app = app; diff --git a/src/libraries/JANA/JFactoryT.h b/src/libraries/JANA/JFactoryT.h index 2e6eddf86..30252b3b6 100644 --- a/src/libraries/JANA/JFactoryT.h +++ b/src/libraries/JANA/JFactoryT.h @@ -25,7 +25,7 @@ class JFactoryT : public JFactory { using IteratorType = typename std::vector::const_iterator; using PairType = std::pair; - JFactoryT() : JFactory(JTypeInfo::demangle(), ""){ + JFactoryT(std::string tag="") : JFactory(JTypeInfo::demangle(), tag){ EnableGetAs(); EnableGetAs( std::is_convertible() ); // Automatically add JObject if this can be converted to it #if JANA2_HAVE_ROOT