Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Label Property on Item Class #14

Open
JeffFerguson opened this issue Jul 13, 2018 · 2 comments
Open

Provide Label Property on Item Class #14

JeffFerguson opened this issue Jul 13, 2018 · 2 comments
Labels
enhancement Enhancement request.

Comments

@JeffFerguson
Copy link
Owner

The Item class should maintain a property of type string called Label, which will return the label from the Label linkbase matching the fact. If no label is available, then the property should evaluate to an empty string.

The sample available in Issue 12 should be used as an implementation starting point for this work.

@JeffFerguson JeffFerguson added the enhancement Enhancement request. label Jul 13, 2018
@ValeriyTitov
Copy link

I think string property is not best way to implement.

  1. According article on page 33 in Xbrl in plain english.pdf each concept (fact) can have more than one label (depending on language, fact value, or other conditions). I supose, label should be list of strings or even own class.

Note that we give each label resource for the same concept the same value for the label attribute. This enables us to use a one-to-many link from a concept to all its labels. In this case three different types of label for the nr_employees_total concept.

  1. Im unsure if im asking right question for finding labels for fact.
    Because "Flat list of facts with label" is not real life example of xbrl-report. Usually for me - its datatable, with Label in its header.
    However, as i understand, xbrl taxononmy can contain presentation level with description of best look.

@JeffFerguson
Copy link
Owner Author

Thank you for the feedback! I'll keep this in mind and read up a bit more before I finalize an implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement request.
Projects
None yet
Development

No branches or pull requests

2 participants